Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 2466923002: headless: Only report protocol parsing errors when DCHECK is enabled (Closed)

Created:
4 years, 1 month ago by Sami
Modified:
4 years, 1 month ago
Reviewers:
altimin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Only report protocol parsing errors when DCHECK is enabled Only report verbose protocol parsing errors when DCHECK is enabled. This reduces the release binary size on Linux by about 77k. BUG=612904 Committed: https://crrev.com/64eaf8939cd0f6e7524923d82e384c29803533cd Cr-Commit-Position: refs/heads/master@{#429017}

Patch Set 1 #

Patch Set 2 : Fix merge error #

Patch Set 3 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M headless/public/util/error_reporter.h View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M headless/public/util/error_reporter.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sami
4 years, 1 month ago (2016-11-01 15:55:21 UTC) #3
altimin
lgtm, thanks!
4 years, 1 month ago (2016-11-01 16:06:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466923002/40001
4 years, 1 month ago (2016-11-01 16:20:07 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-01 16:34:16 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 17:22:18 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/64eaf8939cd0f6e7524923d82e384c29803533cd
Cr-Commit-Position: refs/heads/master@{#429017}

Powered by Google App Engine
This is Rietveld 408576698