Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 2466903003: Fix timeout of paint/invalidation/compositing/should-not-clip*.html (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
chrishtr
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix timeout of paint/invalidation/compositing/should-not-clip*.html The tests contained huge layers and pixel under-invalidation checking is too slow causing the tests to timeout. Shrink the layers. BUG=661269 Committed: https://crrev.com/12a2832bf37b7bcc63b006149db7990f40dc9c25 Cr-Commit-Position: refs/heads/master@{#429184}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Shrink the layers #

Messages

Total messages: 19 (12 generated)
Xianzhu
4 years, 1 month ago (2016-11-01 23:07:36 UTC) #4
chrishtr
https://codereview.chromium.org/2466903003/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/compositing/should-not-clip-composited-overflow-scrolling-layer.html File third_party/WebKit/LayoutTests/paint/invalidation/compositing/should-not-clip-composited-overflow-scrolling-layer.html (right): https://codereview.chromium.org/2466903003/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/compositing/should-not-clip-composited-overflow-scrolling-layer.html#newcode24 third_party/WebKit/LayoutTests/paint/invalidation/compositing/should-not-clip-composited-overflow-scrolling-layer.html:24: width: 5000px; I'd prefer you just reduce the sizes ...
4 years, 1 month ago (2016-11-01 23:25:06 UTC) #6
Xianzhu
https://codereview.chromium.org/2466903003/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/compositing/should-not-clip-composited-overflow-scrolling-layer.html File third_party/WebKit/LayoutTests/paint/invalidation/compositing/should-not-clip-composited-overflow-scrolling-layer.html (right): https://codereview.chromium.org/2466903003/diff/1/third_party/WebKit/LayoutTests/paint/invalidation/compositing/should-not-clip-composited-overflow-scrolling-layer.html#newcode24 third_party/WebKit/LayoutTests/paint/invalidation/compositing/should-not-clip-composited-overflow-scrolling-layer.html:24: width: 5000px; On 2016/11/01 23:25:06, chrishtr wrote: > I'd ...
4 years, 1 month ago (2016-11-01 23:56:41 UTC) #11
chrishtr
lgtm
4 years, 1 month ago (2016-11-02 00:30:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466903003/20001
4 years, 1 month ago (2016-11-02 00:32:24 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 02:12:43 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 02:14:35 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/12a2832bf37b7bcc63b006149db7990f40dc9c25
Cr-Commit-Position: refs/heads/master@{#429184}

Powered by Google App Engine
This is Rietveld 408576698