Issue 2466893004: VM: Restore a test with pointer verification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2466893004: VM: Restore a test with pointer verification (Closed)

Created:
4 years, 1 month ago by Florian Schneider

Modified:
4 years, 1 month ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Restore a test with pointer verification --verify-on-transition now works with OSR and background compilation, so this test can be restored back to enable these. (issues #26149, #26150) R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/5380642554a12a90ff1bac3ec50052d10bf43909

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	runtime/vm/custom_isolate_test.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

I think both OSR and background compilation should work. I could not reproduce any failure ...

4 years, 1 month ago (2016-11-02 14:47:58 UTC) #2

Florian Schneider

4 years, 1 month ago (2016-11-02 18:40:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5380642554a12a90ff1bac3ec50052d10bf43909 (presubmit successful).