content/public/test/memory_coordinator_test_utils.h - Issue 2466883002: Add TabLoaderTest

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/test/memory_coordinator_test_utils.h

Issue 2466883002: Add TabLoaderTest (Closed)

Patch Set: Address on reviews Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_PUBLIC_BROWSER_MEMORY_COORDINATOR_TEST_UTILS_H_

	6 #define CONTENT_PUBLIC_BROWSER_MEMORY_COORDINATOR_TEST_UTILS_H_

	7

	8 namespace content {

	9

	10 // Enables the memory coordinator feature.

	11 void EnableFeaturesForTesting();
	bashi 2016/11/07 14:11:30 content::EnableFeaturesForTesting() sounds a bit g content::EnableFeaturesForTesting() sounds a bit generic to me (that's why I suggested creating a class). Could you name it EnableMemoryCoordinatorForTesting() ? hajimehoshi 2016/11/08 06:03:04 Oops, Done. Show quoted text On 2016/11/07 14:11:30, bashi1 wrote: > content::EnableFeaturesForTesting() sounds a bit generic to me (that's why I > suggested creating a class). Could you name it > EnableMemoryCoordinatorForTesting() ? Oops, Done.
	12

	13 // Sets up MemoryCoordinatorProxy with a regular MemoryCoordinator.

	14 void SetUpMemoryCoordinatorProxyForTesting();

	15

	16 }

	17

	18 #endif // CONTENT_PUBLIC_BROWSER_MEMORY_COORDINATOR_TEST_UTILS_H_

OLD	NEW