Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: components/ntp_snippets/content_suggestions_service.h

Issue 2466863003: Finalize backend for fetching more NTPSnippets. (Closed)
Patch Set: Known suggestion are now a parameter for Fetch. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_service.h
diff --git a/components/ntp_snippets/content_suggestions_service.h b/components/ntp_snippets/content_suggestions_service.h
index 9b1b6664d6da5bd907a6ca7e6a037e8d47bc3dde..9cb37b200c8ea57ba26fbe162529b0a5e7472ec6 100644
--- a/components/ntp_snippets/content_suggestions_service.h
+++ b/components/ntp_snippets/content_suggestions_service.h
@@ -45,7 +45,7 @@ class ContentSuggestionsService : public KeyedService,
using ImageFetchedCallback = base::Callback<void(const gfx::Image&)>;
using DismissedSuggestionsCallback = base::Callback<void(
std::vector<ContentSuggestion> dismissed_suggestions)>;
- using FetchedMoreCallback =
+ using FetchingCallback =
base::Callback<void(std::vector<ContentSuggestion> suggestions)>;
class Observer {
@@ -141,7 +141,9 @@ class ContentSuggestionsService : public KeyedService,
// Fetches additional contents for the given |category|. If the fetch was
// completed, the given |callback| is called with the updated content.
// This includes new and old data.
- void FetchMore(const Category& category, const FetchedMoreCallback& callback);
+ void Fetch(const Category& category,
+ std::set<std::string> known_suggestion_ids,
+ const FetchingCallback& callback);
// Observer accessors.
void AddObserver(Observer* observer);

Powered by Google App Engine
This is Rietveld 408576698