Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Side by Side Diff: content/browser/loader/mojo_async_resource_handler.cc

Issue 2466843002: Cancel the request when URLLoader is gone (Closed)
Patch Set: fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/mojo_async_resource_handler.h" 5 #include "content/browser/loader/mojo_async_resource_handler.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/containers/hash_tables.h" 10 #include "base/containers/hash_tables.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "base/strings/string_number_conversions.h" 13 #include "base/strings/string_number_conversions.h"
14 #include "base/time/time.h" 14 #include "base/time/time.h"
15 #include "content/browser/loader/netlog_observer.h" 15 #include "content/browser/loader/netlog_observer.h"
16 #include "content/browser/loader/resource_dispatcher_host_impl.h" 16 #include "content/browser/loader/resource_dispatcher_host_impl.h"
17 #include "content/browser/loader/resource_request_info_impl.h" 17 #include "content/browser/loader/resource_request_info_impl.h"
18 #include "content/common/resource_request_completion_status.h" 18 #include "content/common/resource_request_completion_status.h"
19 #include "content/public/browser/global_request_id.h"
19 #include "content/public/browser/resource_dispatcher_host_delegate.h" 20 #include "content/public/browser/resource_dispatcher_host_delegate.h"
20 #include "content/public/common/resource_response.h" 21 #include "content/public/common/resource_response.h"
21 #include "mojo/public/c/system/data_pipe.h" 22 #include "mojo/public/c/system/data_pipe.h"
22 #include "mojo/public/cpp/system/data_pipe.h" 23 #include "mojo/public/cpp/system/data_pipe.h"
23 #include "net/base/io_buffer.h" 24 #include "net/base/io_buffer.h"
24 #include "net/base/load_flags.h" 25 #include "net/base/load_flags.h"
25 #include "net/base/mime_sniffer.h" 26 #include "net/base/mime_sniffer.h"
26 #include "net/url_request/redirect_info.h" 27 #include "net/url_request/redirect_info.h"
27 28
28 namespace content { 29 namespace content {
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 net::URLRequest* request, 105 net::URLRequest* request,
105 ResourceDispatcherHostImpl* rdh, 106 ResourceDispatcherHostImpl* rdh,
106 mojom::URLLoaderAssociatedRequest mojo_request, 107 mojom::URLLoaderAssociatedRequest mojo_request,
107 mojom::URLLoaderClientAssociatedPtr url_loader_client) 108 mojom::URLLoaderClientAssociatedPtr url_loader_client)
108 : ResourceHandler(request), 109 : ResourceHandler(request),
109 rdh_(rdh), 110 rdh_(rdh),
110 binding_(this, std::move(mojo_request)), 111 binding_(this, std::move(mojo_request)),
111 url_loader_client_(std::move(url_loader_client)) { 112 url_loader_client_(std::move(url_loader_client)) {
112 DCHECK(url_loader_client_); 113 DCHECK(url_loader_client_);
113 InitializeResourceBufferConstants(); 114 InitializeResourceBufferConstants();
115 // This unretained pointer is safe, because |binding_| is owned by |this| and
116 // the callback will never be called after |this| is destroyed.
117 binding_.set_connection_error_handler(
118 base::Bind(&MojoAsyncResourceHandler::Cancel, base::Unretained(this)));
114 } 119 }
115 120
116 MojoAsyncResourceHandler::~MojoAsyncResourceHandler() { 121 MojoAsyncResourceHandler::~MojoAsyncResourceHandler() {
117 if (has_checked_for_sufficient_resources_) 122 if (has_checked_for_sufficient_resources_)
118 rdh_->FinishedWithResourcesForRequest(request()); 123 rdh_->FinishedWithResourcesForRequest(request());
119 } 124 }
120 125
121 bool MojoAsyncResourceHandler::OnRequestRedirected( 126 bool MojoAsyncResourceHandler::OnRequestRedirected(
122 const net::RedirectInfo& redirect_info, 127 const net::RedirectInfo& redirect_info,
123 ResourceResponse* response, 128 ResourceResponse* response,
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 reported_total_received_bytes_ = total_received_bytes; 241 reported_total_received_bytes_ = total_received_bytes;
237 DCHECK_LE(0, bytes_to_report); 242 DCHECK_LE(0, bytes_to_report);
238 243
239 url_loader_client_->OnDataDownloaded(bytes_downloaded, bytes_to_report); 244 url_loader_client_->OnDataDownloaded(bytes_downloaded, bytes_to_report);
240 } 245 }
241 246
242 void MojoAsyncResourceHandler::FollowRedirect() { 247 void MojoAsyncResourceHandler::FollowRedirect() {
243 NOTIMPLEMENTED(); 248 NOTIMPLEMENTED();
244 } 249 }
245 250
246 void MojoAsyncResourceHandler::Cancel() {
247 NOTIMPLEMENTED();
248 }
249
250 void MojoAsyncResourceHandler::ResumeForTesting() { 251 void MojoAsyncResourceHandler::ResumeForTesting() {
251 Resume(); 252 Resume();
252 } 253 }
253 254
254 void MojoAsyncResourceHandler::SetAllocationSizeForTesting(size_t size) { 255 void MojoAsyncResourceHandler::SetAllocationSizeForTesting(size_t size) {
255 g_allocation_size = size; 256 g_allocation_size = size;
256 } 257 }
257 258
258 MojoResult MojoAsyncResourceHandler::BeginWrite(void** data, 259 MojoResult MojoAsyncResourceHandler::BeginWrite(void** data,
259 uint32_t* available) { 260 uint32_t* available) {
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 return true; 394 return true;
394 395
395 controller()->CancelWithError(net::ERR_INSUFFICIENT_RESOURCES); 396 controller()->CancelWithError(net::ERR_INSUFFICIENT_RESOURCES);
396 return false; 397 return false;
397 } 398 }
398 399
399 void MojoAsyncResourceHandler::OnWritable(MojoResult unused) { 400 void MojoAsyncResourceHandler::OnWritable(MojoResult unused) {
400 Resume(); 401 Resume();
401 } 402 }
402 403
404 void MojoAsyncResourceHandler::Cancel() {
405 const ResourceRequestInfoImpl* info = GetRequestInfo();
406 ResourceDispatcherHostImpl::Get()->CancelRequestFromRenderer(
407 GlobalRequestID(info->GetChildID(), info->GetRequestID()));
408 }
409
403 } // namespace content 410 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/loader/mojo_async_resource_handler.h ('k') | content/browser/loader/resource_dispatcher_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698