Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2466733003: Wait a few swaps to make Pixel_ScissorTestWithPreserveDrawingBuffer more robust. (Closed)

Created:
4 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
Zhenyao Mo, ccameron
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wait a few swaps to make Pixel_ScissorTestWithPreserveDrawingBuffer more robust. Remove a stale failure expectation for this test. BUG=540039, 660461 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org Committed: https://crrev.com/d805f7422e548f673533dc36e39ab9f8429eb616 Cr-Commit-Position: refs/heads/master@{#429193}

Patch Set 1 #

Patch Set 2 : Try waiting 15 swaps, like the other pixel tests. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M content/test/data/gpu/pixel_scissor.html View 1 1 chunk +14 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
Ken Russell (switch to Gerrit)
FYI. CQ'ing TBR'd.
4 years, 1 month ago (2016-11-01 02:22:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466733003/1
4 years, 1 month ago (2016-11-01 02:22:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/326202)
4 years, 1 month ago (2016-11-01 03:31:05 UTC) #8
Ken Russell (switch to Gerrit)
On 2016/11/01 03:31:05, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 1 month ago (2016-11-01 03:56:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466733003/20001
4 years, 1 month ago (2016-11-01 04:04:37 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_optional_gpu_tests_rel/builds/842)
4 years, 1 month ago (2016-11-01 06:04:49 UTC) #13
Ken Russell (switch to Gerrit)
On 2016/11/01 06:04:49, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 1 month ago (2016-11-02 01:45:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466733003/40001
4 years, 1 month ago (2016-11-02 01:47:08 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-02 02:54:11 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 02:55:46 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d805f7422e548f673533dc36e39ab9f8429eb616
Cr-Commit-Position: refs/heads/master@{#429193}

Powered by Google App Engine
This is Rietveld 408576698