Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3835)

Unified Diff: cc/resources/tile_manager.h

Issue 246673005: cc: Start using raster/eviction iterators in tile manager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/tile_manager.h
diff --git a/cc/resources/tile_manager.h b/cc/resources/tile_manager.h
index 0881e6f6ff1e4a4b556b7ce8830c276c1a8c5ae7..7d5341d16a358398c91f22599da0c2e3de443644 100644
--- a/cc/resources/tile_manager.h
+++ b/cc/resources/tile_manager.h
@@ -20,7 +20,6 @@
#include "cc/resources/managed_tile_state.h"
#include "cc/resources/memory_history.h"
#include "cc/resources/picture_pile_impl.h"
-#include "cc/resources/prioritized_tile_set.h"
#include "cc/resources/rasterizer.h"
#include "cc/resources/resource_pool.h"
#include "cc/resources/tile.h"
@@ -120,7 +119,7 @@ class CC_EXPORT TileManager : public RasterizerClient,
~EvictionTileIterator();
EvictionTileIterator& operator++();
- operator bool() const;
+ operator bool();
Tile* operator*();
private:
@@ -151,6 +150,10 @@ class CC_EXPORT TileManager : public RasterizerClient,
TreePriority tree_priority_;
};
+ void Initialize();
+
+ bool initialized_;
+ TileManager* tile_manager_;
std::vector<PairedPictureLayerIterator> paired_iterators_;
std::vector<PairedPictureLayerIterator*> iterator_heap_;
TreePriority tree_priority_;
@@ -223,10 +226,7 @@ class CC_EXPORT TileManager : public RasterizerClient,
const GlobalStateThatImpactsTilePriority& state) {
// Soft limit is used for resource pool such that
// memory returns to soft limit after going over.
- if (state != global_state_) {
- global_state_ = state;
- prioritized_tiles_dirty_ = true;
- }
+ global_state_ = state;
}
void SetRasterizerForTesting(Rasterizer* rasterizer);
@@ -240,13 +240,10 @@ class CC_EXPORT TileManager : public RasterizerClient,
Rasterizer* rasterizer,
RenderingStatsInstrumentation* rendering_stats_instrumentation);
- // Methods called by Tile
- friend class Tile;
- void DidChangeTilePriority(Tile* tile);
-
void CleanUpReleasedTiles();
// Overriden from RefCountedManager<Tile>:
+ friend class Tile;
virtual void Release(Tile* tile) OVERRIDE;
// Overriden from RasterizerClient:
@@ -261,11 +258,21 @@ class CC_EXPORT TileManager : public RasterizerClient,
virtual void ScheduleTasks(
const TileVector& tiles_that_need_to_be_rasterized);
- void AssignGpuMemoryToTiles(PrioritizedTileSet* tiles,
- TileVector* tiles_that_need_to_be_rasterized);
- void GetTilesWithAssignedBins(PrioritizedTileSet* tiles);
+ void AssignGpuMemoryToTiles(TileVector* tiles_that_need_to_be_rasterized);
private:
+ struct MemoryBudget {
+ int64 soft_memory_bytes;
+ int64 hard_memory_bytes;
+ int resource_count;
+
+ bool Exceeds(const MemoryBudget& other) const {
+ return soft_memory_bytes > other.soft_memory_bytes ||
+ hard_memory_bytes > other.hard_memory_bytes ||
+ resource_count > other.resource_count;
+ }
+ };
+
void OnImageDecodeTaskCompleted(int layer_id,
SkPixelRef* pixel_ref,
bool was_canceled);
@@ -288,8 +295,14 @@ class CC_EXPORT TileManager : public RasterizerClient,
SkPixelRef* pixel_ref);
scoped_refptr<RasterTask> CreateRasterTask(Tile* tile);
scoped_ptr<base::Value> GetMemoryRequirementsAsValue() const;
- void UpdatePrioritizedTileSetIfNeeded();
+ bool FreeTileResourcesUntilUsageIsWithinBudget(
+ EvictionTileIterator* eviction_iterator,
+ const MemoryBudget& required_budget,
+ MemoryBudget* current_budget,
+ const TilePriority& max_priority,
+ bool evict_unconditionally);
void CleanUpLayers();
+ bool TilePriorityViolatesMemoryPolicy(const TilePriority& priority);
bool IsReadyToActivate() const;
void ScheduleCheckIfReadyToActivate();
@@ -304,17 +317,12 @@ class CC_EXPORT TileManager : public RasterizerClient,
typedef base::hash_map<Tile::Id, Tile*> TileMap;
TileMap tiles_;
- PrioritizedTileSet prioritized_tiles_;
- bool prioritized_tiles_dirty_;
-
bool all_tiles_that_need_to_be_rasterized_have_memory_;
bool all_tiles_required_for_activation_have_memory_;
- size_t memory_required_bytes_;
- size_t memory_nice_to_have_bytes_;
-
size_t bytes_releasable_;
size_t resources_releasable_;
+ size_t bytes_required_but_not_allocated_;
bool ever_exceeded_memory_budget_;
MemoryHistory::Entry memory_stats_from_last_assign_;
« no previous file with comments | « cc/resources/tile.cc ('k') | cc/resources/tile_manager.cc » ('j') | cc/resources/tile_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698