Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2466723002: Android FRE: Use CachedMetrics API for histograms. (Closed)

Created:
4 years, 1 month ago by Alexei Svitkine (slow)
Modified:
4 years, 1 month ago
Reviewers:
Ted C, gogerald1
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android FRE: Use CachedMetrics API for histograms. I'm working on making it possible to show the first FRE screen before native is initialized. RecordHistograms API requires native to be initialized. This switches to using CachedMetrics API which supports logging before then. BUG=632199 Committed: https://crrev.com/2770c135dab4859008af3b73c0cc7ed2bea98acc Cr-Commit-Position: refs/heads/master@{#429317}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java View 1 5 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Alexei Svitkine (slow)
4 years, 1 month ago (2016-11-01 15:10:07 UTC) #6
gogerald1
lgtm with a comment https://codereview.chromium.org/2466723002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java File chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java (right): https://codereview.chromium.org/2466723002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java#newcode81 chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java:81: private static final String FRE_ENTRY_VIEW_INTENT ...
4 years, 1 month ago (2016-11-02 13:58:15 UTC) #7
Alexei Svitkine (slow)
https://codereview.chromium.org/2466723002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java File chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java (right): https://codereview.chromium.org/2466723002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java#newcode81 chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java:81: private static final String FRE_ENTRY_VIEW_INTENT = ".ViewIntent"; On 2016/11/02 ...
4 years, 1 month ago (2016-11-02 15:36:36 UTC) #8
Alexei Svitkine (slow)
+tedchoc for owners
4 years, 1 month ago (2016-11-02 15:43:52 UTC) #10
Ted C
lgtm
4 years, 1 month ago (2016-11-02 16:46:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466723002/20001
4 years, 1 month ago (2016-11-02 16:48:05 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 17:25:08 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 17:56:26 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2770c135dab4859008af3b73c0cc7ed2bea98acc
Cr-Commit-Position: refs/heads/master@{#429317}

Powered by Google App Engine
This is Rietveld 408576698