Get code to format from 'overlayState' or from the Source.

Get code to format from 'overlayState' or from the Source.

So, formatting will work for both old and new branches.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/c1a6321707d0bba03feabfff548e559a63eaa70f

[Brian Wilkerson, 2016-10-31 20:17:23]

lgtm

https://codereview.chromium.org/2466703002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2466703002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:849: //   
sink.writeln('$indent$msg');
I don't understand this change. Why are we not writing to the sink? And if we're
not going to write, why not also comment out the unused variable?

[scheglov, 2016-10-31 20:42:38]

https://codereview.chromium.org/2466703002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2466703002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:849: //   
sink.writeln('$indent$msg');
On 2016/10/31 20:17:23, Brian Wilkerson wrote:
> I don't understand this change. Why are we not writing to the sink? And if
we're
> not going to write, why not also comment out the unused variable?

I forgot to roll this change back.

[scheglov, 2016-10-31 20:42:47]

Description was changed from

==========
Get code to format from 'overlayState' or from the Source.

So, formatting will work for both old and new branches.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Get code to format from 'overlayState' or from the Source.

So, formatting will work for both old and new branches.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/c1a6321707d0bba03feabfff548e559a63eaa70f
==========

[scheglov, 2016-10-31 20:42:49]

Committed patchset #1 (id:1) manually as
c1a6321707d0bba03feabfff548e559a63eaa70f (presubmit successful).