Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 24667003: Fix File stream on cancel. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix File stream on cancel. Before we could end up having both an issued read and a close request. Given the new nature of our io-service, this could lead to a race condition between the two. BUG=https://code.google.com/p/dart/issues/detail?id=12982 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27955

Patch Set 1 #

Patch Set 2 : Code cleanup #

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M sdk/lib/io/file_impl.dart View 1 2 4 chunks +16 lines, -6 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 2 months ago (2013-09-26 14:12:02 UTC) #1
Søren Gjesse
LGTM Don't we have the same kind of issues with RandomAccessFile, where a close can ...
7 years, 2 months ago (2013-09-26 14:28:38 UTC) #2
Anders Johnsen
We do. Should we add a boolean to mark when it's being used, so we ...
7 years, 2 months ago (2013-09-26 14:33:28 UTC) #3
Anders Johnsen
7 years, 2 months ago (2013-09-26 14:34:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r27955 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698