Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: chrome/browser/chromeos/net/network_throttling_observer_unittest.cc

Issue 2466693002: [Re-land] Add network throttling as enterprise policy (Closed)
Patch Set: [Re-land] Add network throttling as enterprise policy Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include <memory>
6
7 #include "base/message_loop/message_loop.h"
8 #include "chrome/browser/chromeos/net/network_throttling_observer.h"
9 #include "chrome/common/pref_names.h"
10 #include "chromeos/dbus/dbus_thread_manager.h"
11 #include "chromeos/dbus/mock_shill_manager_client.h"
12 #include "chromeos/network/network_state_handler.h"
13 #include "components/prefs/pref_registry_simple.h"
14 #include "components/prefs/testing_pref_service.h"
15 #include "testing/gmock/include/gmock/gmock.h"
16 #include "testing/gtest/include/gtest/gtest.h"
17
18 using testing::_;
19 using testing::Mock;
20 using testing::NiceMock;
21
22 namespace chromeos {
23
24 namespace test {
25
26 class NetworkThrottlingObserverTest : public ::testing::Test {
27 public:
28 NetworkThrottlingObserverTest() {
29 std::unique_ptr<DBusThreadManagerSetter> dbus_setter =
30 DBusThreadManager::GetSetterForTesting();
31 // Owned by DBusThreadManager, which takes care of cleaning it
32 mock_manager_client_ = new NiceMock<MockShillManagerClient>();
33 dbus_setter->SetShillManagerClient(
34 std::unique_ptr<ShillManagerClient>(mock_manager_client_));
35 network_state_handler_ = NetworkStateHandler::InitializeForTest();
36 NetworkHandler::Initialize();
37 local_state_ = base::MakeUnique<TestingPrefServiceSimple>();
38 local_state_->registry()->RegisterDictionaryPref(
39 prefs::kNetworkThrottlingEnabled);
40 observer_ = base::MakeUnique<NetworkThrottlingObserver>(local_state_.get());
41 }
42
43 ~NetworkThrottlingObserverTest() override {
44 observer_.reset();
45 local_state_.reset();
46 network_state_handler_.reset();
47 NetworkHandler::Shutdown();
48 DBusThreadManager::Shutdown();
49 }
50
51 base::MessageLoop message_loop_;
52 std::unique_ptr<NetworkStateHandler> network_state_handler_;
53 std::unique_ptr<TestingPrefServiceSimple> local_state_;
54 std::unique_ptr<NetworkThrottlingObserver> observer_;
55 MockShillManagerClient* mock_manager_client_;
56
57 private:
58 DISALLOW_COPY_AND_ASSIGN(NetworkThrottlingObserverTest);
59 };
60
61 TEST_F(NetworkThrottlingObserverTest, ThrottlingChangeCallsShill) {
62 // Test that a change in the throttling policy value leads to
63 // shill_manager_client being called.
64 base::DictionaryValue updated_throttling_policy;
65 bool enabled = true;
66 uint32_t upload_rate = 1200;
67 uint32_t download_rate = 2000;
68 updated_throttling_policy.SetBoolean("enabled", enabled);
69 updated_throttling_policy.SetInteger("upload_rate_kbits", upload_rate);
70 updated_throttling_policy.SetInteger("download_rate_kbits", download_rate);
71 EXPECT_CALL(
72 *mock_manager_client_,
73 SetNetworkThrottlingStatus(enabled, upload_rate, download_rate, _, _))
74 .Times(1);
75 local_state_->Set(prefs::kNetworkThrottlingEnabled,
76 updated_throttling_policy);
77 Mock::VerifyAndClearExpectations(mock_manager_client_);
78
79 // Clearing the preference should disable throttling
80 EXPECT_CALL(*mock_manager_client_,
81 SetNetworkThrottlingStatus(false, 0, 0, _, _))
82 .Times(1);
83 local_state_->ClearPref(prefs::kNetworkThrottlingEnabled);
84 }
85
86 } // namespace test
87 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698