runtime/vm/branch_optimizer.cc - Issue 2466643002: AOT: Enable branch merging for checked smi comparisons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/branch_optimizer.cc

Issue 2466643002: AOT: Enable branch merging for checked smi comparisons (Closed)

Patch Set: addressed comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/branch_optimizer.cc

diff --git a/runtime/vm/branch_optimizer.cc b/runtime/vm/branch_optimizer.cc

index 4ad12c1a06583fc2a9e6f315d8ca74e6781845f3..567a2bf99d915e6d356bf8ffc0e6804a8b040cd6 100644

--- a/runtime/vm/branch_optimizer.cc

+++ b/runtime/vm/branch_optimizer.cc

@@ -47,6 +47,9 @@ bool BranchSimplifier::Match(JoinEntryInstr* block) {

if (comparison->InputCount() != 2) {

return false;

}

+ if (comparison->CanDeoptimize() || comparison->MayThrow()) {

+ return false;

+ }

Value* left = comparison->left();

PhiInstr* phi = left->definition()->AsPhi();

Value* right = comparison->right();

« no previous file with comments | « runtime/vm/aot_optimizer.cc ('k') | runtime/vm/constant_propagator.cc » ('j') | no next file with comments »