Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2466633002: [Devtools] Fixed scrollers for new timeline canvas on mac (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed scrollers for new timeline canvas on mac This patch fixes issue where scrollbars were not being shown on mac for the new canvas timeline in network panel. R=dgozman BUG=653738 Committed: https://crrev.com/54f00059c2af3138080c7598dc487d18d3eef50e Cr-Commit-Position: refs/heads/master@{#428803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/networkTimelineColumn.css View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
allada
PTL
4 years, 1 month ago (2016-10-31 19:01:19 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-10-31 19:47:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466633002/1
4 years, 1 month ago (2016-10-31 20:43:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 20:53:20 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 20:56:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54f00059c2af3138080c7598dc487d18d3eef50e
Cr-Commit-Position: refs/heads/master@{#428803}

Powered by Google App Engine
This is Rietveld 408576698