Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2466593002: Updating --site-per-process expectations for insecure-plugin-in-iframe.html (Closed)

Created:
4 years, 1 month ago by Łukasz Anforowicz
Modified:
4 years, 1 month ago
Reviewers:
alexmos
CC:
chromium-reviews, blink-reviews, rune, nasko, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating --site-per-process expectations for insecure-plugin-in-iframe.html The test stopped crashing in --site-per-process mode after r428312. A new bug has been opened for the remaining text diff in test output. BUG=582494, 660872 NOTRY=true Committed: https://crrev.com/0c709a831773d24b82e64888eae63e3dda9c9d66 Cr-Commit-Position: refs/heads/master@{#428745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Łukasz Anforowicz
Alex, can you take a look please?
4 years, 1 month ago (2016-10-31 16:29:08 UTC) #3
alexmos
LGTM. I guess it's the same problem, since the old bug also had updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks on ...
4 years, 1 month ago (2016-10-31 16:46:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466593002/1
4 years, 1 month ago (2016-10-31 16:55:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 16:59:42 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 17:16:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c709a831773d24b82e64888eae63e3dda9c9d66
Cr-Commit-Position: refs/heads/master@{#428745}

Powered by Google App Engine
This is Rietveld 408576698