Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2466573002: [stubs] Fix allocation memento detection. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fix allocation memento detection. The old code does not work properly when the allocation memento object ends exactly at page boundary. This CL addresses DBC mentioned in https://codereview.chromium.org/2313093002/ BUG=v8:5269 Committed: https://crrev.com/70d2b685ae0b3c2b8575d05c9c815bd44b662286 Cr-Commit-Position: refs/heads/master@{#40676}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -48 lines) Patch
M src/arm/macro-assembler-arm.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/code-stub-assembler.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-10-31 15:26:09 UTC) #6
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-10-31 15:45:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466573002/1
4 years, 1 month ago (2016-10-31 15:47:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 15:50:42 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:19 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70d2b685ae0b3c2b8575d05c9c815bd44b662286
Cr-Commit-Position: refs/heads/master@{#40676}

Powered by Google App Engine
This is Rietveld 408576698