Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2466563002: Remove DCHECK that transferred array buffers are neutered or shared. (Closed)

Created:
4 years, 1 month ago by jbroman
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove DCHECK that transferred array buffers are neutered or shared. While this seems like it should be true, the array buffer is not actually neutered until the end of cloning. This is so that, if an exception is thrown during serialization, the original array buffer is not left neutered. As a result, Blink will not have neutered the buffer. This fixes some DCHECK failures during layout tests. BUG=chromium:148757 Committed: https://crrev.com/fa33489ffd6a9de73a6852053e14460aa8700527 Cr-Commit-Position: refs/heads/master@{#40675}

Patch Set 1 #

Patch Set 2 : now with unit test update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/value-serializer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 4 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
jbroman
4 years, 1 month ago (2016-10-31 15:09:33 UTC) #6
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-10-31 15:13:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466563002/20001
4 years, 1 month ago (2016-10-31 15:17:22 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 15:23:19 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:16 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa33489ffd6a9de73a6852053e14460aa8700527
Cr-Commit-Position: refs/heads/master@{#40675}

Powered by Google App Engine
This is Rietveld 408576698