Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 2466553002: [ic] Simplify handling of primitive maps. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Simplify handling of primitive maps. This CL adds support for primitive maps to 1) PrototypeIterator, 2) PropertyHandlerCompiler::CheckPrototypes(), 3) Map::GetOrCreatePrototypeChainValidityCell(), 4) Prototype checks in data-driven ICs. BUG=v8:5561 Committed: https://crrev.com/7c22a153e2ba5099523118f5c085b52d887f32ea Cr-Commit-Position: refs/heads/master@{#40673}

Patch Set 1 : Try with disabled data-driven ICs #

Patch Set 2 : Now with enabled data-drived ICs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -191 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 4 chunks +4 lines, -17 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 4 chunks +4 lines, -17 lines 0 comments Download
M src/ic/handler-compiler.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/ic/handler-compiler.cc View 2 chunks +2 lines, -17 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 4 chunks +4 lines, -17 lines 0 comments Download
M src/ic/ic.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 4 chunks +4 lines, -17 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 4 chunks +4 lines, -17 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 5 chunks +4 lines, -17 lines 0 comments Download
M src/ic/s390/handler-compiler-s390.cc View 4 chunks +4 lines, -16 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 4 chunks +4 lines, -17 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 4 chunks +4 lines, -17 lines 0 comments Download
M src/lookup.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/objects.cc View 3 chunks +11 lines, -6 lines 0 comments Download
M src/prototype.h View 4 chunks +11 lines, -10 lines 0 comments Download
M src/string-stream.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-10-31 14:38:45 UTC) #11
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-10-31 14:47:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466553002/80001
4 years, 1 month ago (2016-10-31 14:49:45 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 1 month ago (2016-10-31 14:58:46 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:10 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c22a153e2ba5099523118f5c085b52d887f32ea
Cr-Commit-Position: refs/heads/master@{#40673}

Powered by Google App Engine
This is Rietveld 408576698