Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2466543002: WebRTC: Configure more_configs recipe for new Android builders. (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

WebRTC: Configure more_configs recipe for new Android builders. Fix missing recipe configs in https://codereview.chromium.org/2457423002. Ensure they use the classic annotator_factory instead of remote_run, to make it easier to add unit tests without having to deal with all the boilerplate code needed for remote_run in order to get the right paths. BUG=652197, 611054 Committed: https://chromium.googlesource.com/chromium/tools/build/+/8ffc672e2003b9e5aa2f9839075ba55fd202a4be

Patch Set 1 #

Patch Set 2 : Fix annotator_factory import #

Patch Set 3 : Makeing sure tryserver bot also uses annotator_factory #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M masters/master.client.webrtc/master_android_cfg.py View 1 3 chunks +12 lines, -2 lines 0 comments Download
M masters/master.tryserver.webrtc/master.cfg View 1 2 2 chunks +7 lines, -2 lines 1 comment Download

Messages

Total messages: 18 (12 generated)
kjellander_chromium
4 years, 1 month ago (2016-10-31 13:31:37 UTC) #4
kjellander_chromium
Now it works...
4 years, 1 month ago (2016-10-31 21:12:40 UTC) #11
kjellander_chromium
PTAL https://codereview.chromium.org/2466543002/diff/40001/masters/master.tryserver.webrtc/master.cfg File masters/master.tryserver.webrtc/master.cfg (right): https://codereview.chromium.org/2466543002/diff/40001/masters/master.tryserver.webrtc/master.cfg#newcode154 masters/master.tryserver.webrtc/master.cfg:154: 'webrtc/more_configs',) without this line both of the "more ...
4 years, 1 month ago (2016-11-01 08:20:09 UTC) #13
ehmaldonado_chromium
On 2016/11/01 08:20:09, kjellander_chromium wrote: > PTAL > > https://codereview.chromium.org/2466543002/diff/40001/masters/master.tryserver.webrtc/master.cfg > File masters/master.tryserver.webrtc/master.cfg (right): > ...
4 years, 1 month ago (2016-11-01 08:24:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466543002/40001
4 years, 1 month ago (2016-11-01 08:30:16 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 08:40:32 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/8ffc672e2003b9e5aa2f...

Powered by Google App Engine
This is Rietveld 408576698