Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2466533003: Use old assertion text script in precompiled mode (Closed)

Created:
4 years, 1 month ago by Cutch
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update language.status #

Total comments: 2

Patch Set 3 : fschneider review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M runtime/lib/errors.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Cutch
4 years, 1 month ago (2016-10-31 16:03:03 UTC) #3
Cutch
4 years, 1 month ago (2016-10-31 16:04:03 UTC) #4
Florian Schneider
lgtm https://codereview.chromium.org/2466533003/diff/20001/runtime/lib/errors.cc File runtime/lib/errors.cc (right): https://codereview.chromium.org/2466533003/diff/20001/runtime/lib/errors.cc#newcode17 runtime/lib/errors.cc:17: if (FLAG_precompiled_runtime) { Add a comment about what ...
4 years, 1 month ago (2016-10-31 16:07:05 UTC) #5
Cutch
https://codereview.chromium.org/2466533003/diff/20001/runtime/lib/errors.cc File runtime/lib/errors.cc (right): https://codereview.chromium.org/2466533003/diff/20001/runtime/lib/errors.cc#newcode17 runtime/lib/errors.cc:17: if (FLAG_precompiled_runtime) { On 2016/10/31 16:07:05, Florian Schneider wrote: ...
4 years, 1 month ago (2016-10-31 16:13:11 UTC) #6
Cutch
Committed patchset #3 (id:40001) manually as d62e41fcea8fee5aa69f0875eb4f151abfdcc74e (presubmit successful).
4 years, 1 month ago (2016-10-31 16:14:01 UTC) #8
rmacnak
4 years, 1 month ago (2016-10-31 16:14:40 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698