Issue 2466533002: Mark test as runtime failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2466533002: Mark test as runtime failure (Closed)

Created:
4 years, 1 month ago by vsm

Modified:
4 years, 1 month ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Mark test as runtime failure pkg collection is now clean. TBR=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/e8fbfc4f0df538fd46388081e0fb2fd3bbf9ad48

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/dev_compiler/test/browser/language_tests.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	pkg/dev_compiler/test/not_yet_strong_tests.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

Committed patchset #1 (id:1) manually as e8fbfc4f0df538fd46388081e0fb2fd3bbf9ad48 (presubmit successful).

4 years, 1 month ago (2016-10-31 13:01:06 UTC) #2

vsm

On 2016/10/31 13:01:06, vsm wrote: > Committed patchset #1 (id:1) manually as > e8fbfc4f0df538fd46388081e0fb2fd3bbf9ad48 (presubmit ...

4 years, 1 month ago (2016-10-31 13:59:20 UTC) #3

Jennifer Messerly

4 years, 1 month ago (2016-10-31 21:39:31 UTC) #5

Message was sent while issue was closed.

On 2016/10/31 13:59:20, vsm wrote:
> On 2016/10/31 13:01:06, vsm wrote:
> > Committed patchset #1 (id:1) manually as
> > e8fbfc4f0df538fd46388081e0fb2fd3bbf9ad48 (presubmit successful).
> 
> BTW, any reason we're not building collection in buiild_test_pkgs.sh?

no reason that I know of :)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages