Settings Overides -- warn user when extensions override their NTP.

chrome/browser/ui/DEPS

Index: chrome/browser/ui/DEPS
diff --git a/chrome/browser/ui/DEPS b/chrome/browser/ui/DEPS
index 0abd903a2d142c3c71211c00c398ada70710bceb..fe0d42a6b7b1f7dd0a431ae790d3ebb061ff3e9f 100644
--- a/chrome/browser/ui/DEPS
+++ b/chrome/browser/ui/DEPS
@@ -1,4 +1,5 @@
 include_rules = [
   "+components/auto_login_parser",
   "-chrome/browser/ui/views",
+  "+chrome/browser/ui/views/settings_api_bubble_helper_views.h"

[Finnur, 2014/04/22 18:16:33]

I'll admit, this is a bit unfortunate. Is there a way to accomplish the same
without a wholesale refactor of how NewTab works? I'm drawing a blank... :/

[sky, 2014/04/22 22:13:27]

Yes, we definitely don't want this dependency here. Probably best to call your
function
from BrowserView::TabInsertedAt. You'll need a check of the URL, and you'll have
to be careful you don't accidentally show when dragging a tab from one window to
another.

[Finnur, 2014/04/23 13:51:35]

Thanks for the suggestion!

It turns out I don't need to worry about dragging. You can't drag a tab that
hasn't been created and this one-time bubble only shows up the first time the
new tab page is created. I did check, though, to see if the tab being created is
in the foreground, because that's consistent with when we want to show the
bubble (no bubble for background tabs, ever) -- and that flag, incidentally, is
set to false when dragging, so that should cover dragging as well (if it were to
come to that).

 ]