chrome/browser/ui/DEPS - Issue 246653003: Settings Overides -- warn user when extensions override their NTP.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/DEPS

Issue 246653003: Settings Overides -- warn user when extensions override their NTP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Polish Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/ntp_controlled_bubble_controller.cc ('K') | « chrome/browser/extensions/ntp_controlled_bubble_controller.cc ('k') | chrome/browser/ui/browser_tabstrip.cc » ('j') | chrome/browser/ui/views/settings_api_bubble_helper_views.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/auto_login_parser",	2 "+components/auto_login_parser",

3 "-chrome/browser/ui/views",	3 "-chrome/browser/ui/views",

	4 "+chrome/browser/ui/views/settings_api_bubble_helper_views.h"
	Finnur 2014/04/22 18:16:33 I'll admit, this is a bit unfortunate. Is there a I'll admit, this is a bit unfortunate. Is there a way to accomplish the same without a wholesale refactor of how NewTab works? I'm drawing a blank... :/ sky 2014/04/22 22:13:27 Yes, we definitely don't want this dependency here Show quoted text On 2014/04/22 18:16:33, Finnur wrote: > I'll admit, this is a bit unfortunate. Is there a way to accomplish the same > without a wholesale refactor of how NewTab works? I'm drawing a blank... :/ Yes, we definitely don't want this dependency here. Probably best to call your function from BrowserView::TabInsertedAt. You'll need a check of the URL, and you'll have to be careful you don't accidentally show when dragging a tab from one window to another. Finnur 2014/04/23 13:51:35 Thanks for the suggestion! It turns out I don't n Thanks for the suggestion! It turns out I don't need to worry about dragging. You can't drag a tab that hasn't been created and this one-time bubble only shows up the first time the new tab page is created. I did check, though, to see if the tab being created is in the foreground, because that's consistent with when we want to show the bubble (no bubble for background tabs, ever) -- and that flag, incidentally, is set to false when dragging, so that should cover dragging as well (if it were to come to that).
4 ]	5 ]

OLD	NEW