third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp - Issue 2466513002: Deprecate ServiceWorkerMessageEvent in favor of MessageEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

Issue 2466513002: Deprecate ServiceWorkerMessageEvent in favor of MessageEvent (Closed)

Patch Set: Remove ServiceWorkerMessageEvent codes; update layout tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/serviceworker/serviceworker-message-event-historical.html ('K') | « third_party/WebKit/LayoutTests/http/tests/serviceworker/serviceworker-message-event-historical.html ('k') | third_party/WebKit/Source/bindings/modules/BUILD.gn » ('j') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

index 371e345ba7b3bd02c021295bb6ed1acbc70b0ef0..8de16ad95a1bf1599af87bf703cd326ecc8bec7f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

@@ -110,7 +110,7 @@ void V8MessageEvent::initMessageEventMethodCustom(

v8::Local<v8::Value> dataArg = info[3];

TOSTRING_VOID(V8StringResource<>, originArg, info[4]);

TOSTRING_VOID(V8StringResource<>, lastEventIdArg, info[5]);

- DOMWindow* sourceArg = toDOMWindow(info.GetIsolate(), info[6]);

+ EventTarget* sourceArg = toEventTarget(info.GetIsolate(), info[6]);

MessagePortArray* portArray = nullptr;

const int portArrayIndex = 7;

if (!isUndefinedOrNull(info[portArrayIndex])) {