Chromium Code Reviews Chromium Code Reviews
Issue 2466513002:
Deprecate ServiceWorkerMessageEvent in favor of MessageEvent (Closed)
| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <title>Service Worker: postMessage to Client</title> | 2 <title>Service Worker: postMessage to Client</title> |
| 3 <script src="../resources/testharness.js"></script> | 3 <script src="../resources/testharness.js"></script> |
| 4 <script src="../resources/testharnessreport.js"></script> | 4 <script src="../resources/testharnessreport.js"></script> |
| 5 <script src="resources/test-helpers.js"></script> | 5 <script src="resources/test-helpers.js"></script> |
| 6 <script> | 6 <script> |
| 7 | 7 |
| 8 promise_test(t => { | 8 promise_test(t => { |
| 9 var script = 'resources/postmessage-to-client-worker.js'; | 9 var script = 'resources/postmessage-to-client-worker.js'; |
| 10 var scope = 'resources/blank.html'; | 10 var scope = 'resources/blank.html'; |
| 11 var w; | 11 var w; |
| 12 | 12 |
| 13 return service_worker_unregister_and_register(t, script, scope) | 13 return service_worker_unregister_and_register(t, script, scope) |
| 14 .then(registration => { | 14 .then(registration => { |
| 15 add_completion_callback(() => registration.unregister()); | 15 add_completion_callback(() => registration.unregister()); |
| 16 return wait_for_state(t, registration.installing, 'activated'); | 16 return wait_for_state(t, registration.installing, 'activated'); |
| 17 }) | 17 }) |
| 18 .then(() => with_iframe(scope)) | 18 .then(() => with_iframe(scope)) |
| 19 .then(frame => { | 19 .then(frame => { |
| 20 return new Promise(resolve => { | 20 return new Promise(resolve => { |
| 21 w = frame.contentWindow; | 21 w = frame.contentWindow; |
| 22 w.navigator.serviceWorker.onmessage = resolve; | 22 w.navigator.serviceWorker.onmessage = resolve; |
| 23 w.navigator.serviceWorker.controller.postMessage('ping'); | 23 w.navigator.serviceWorker.controller.postMessage('ping'); |
| 24 }); | 24 }); |
| 25 }) | 25 }) |
| 26 .then(e => { | 26 .then(e => { |
| 27 var message = e.data; | 27 var message = e.data; |
| 28 assert_equals(e.origin, location.origin, | 28 assert_equals(self.ServiceWorkerMessageEvent, undefined, |
| 29 'origin of message should be origin of Service Worker'); | 29 'ServiceWorkerMessageEvent should not be defined.'); |
|
nhiroki
2016/11/15 03:42:15
This assertion wouldn't be necessary because it's
jungkees
2016/11/15 16:06:49
Removed this assertion.
| |
| 30 assert_equals(e.constructor, w.MessageEvent, | |
| 31 'message events should use MessageEvent interface.'); | |
| 32 assert_equals(e.type, 'message', 'type should be "message".'); | |
| 33 assert_equals( | |
| 34 e.origin, location.origin, | |
| 35 'origin of message should be origin of Service Worker.'); | |
| 30 assert_equals(e.lastEventId, '', | 36 assert_equals(e.lastEventId, '', |
| 31 'lastEventId should be an empty string'); | 37 'lastEventId should be an empty string.'); |
| 38 assert_equals(e.source.constructor, w.ServiceWorker, | |
| 39 'source should use ServiceWorker interface.'); | |
| 40 assert_equals( | |
| 41 e.source, w.navigator.serviceWorker.controller, | |
| 42 'source should be the service worker that sent the message.'); | |
| 43 assert_equals(e.ports.length, 0, 'ports should be an empty array.'); | |
| 32 assert_equals(message, 'Sending message via clients'); | 44 assert_equals(message, 'Sending message via clients'); |
| 33 return new Promise(resolve => { | 45 return new Promise(resolve => { |
| 34 w.navigator.serviceWorker.onmessage = resolve; | 46 w.navigator.serviceWorker.onmessage = resolve; |
| 35 }); | 47 }); |
| 36 }) | 48 }) |
| 37 .then(e => { assert_equals(e.data, 'quit'); }); | 49 .then(e => { assert_equals(e.data, 'quit'); }); |
| 38 }, 'postMessage from ServiceWorker to Client'); | 50 }, 'postMessage from ServiceWorker to Client.'); |
| 39 | 51 |
| 40 </script> | 52 </script> |
| OLD | NEW |
