Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2466463002: Revert of [Sync] IWYU cleanup. (Closed)

Created:
4 years, 1 month ago by phoglund_chromium
Modified:
4 years, 1 month ago
Reviewers:
maxbogue, skym
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sync] IWYU cleanup. (patchset #1 id:1 of https://codereview.chromium.org/2460703005/ ) Reason for revert: Likely made sync tests flaky. See https://bugs.chromium.org/p/chromium/issues/detail?id=660655 for more details. BUG=660655 Original issue's description: > [Sync] IWYU cleanup. > > BUG= > > Committed: https://crrev.com/ef2d347246bfc3cb768a92a5000883379bd51b88 > Cr-Commit-Position: refs/heads/master@{#428559} TBR=maxbogue@chromium.org,skym@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/e8d55b3d552a5d23c8c71da157c2f4bbdab56130 Cr-Commit-Position: refs/heads/master@{#428685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M chrome/browser/sync/chrome_sync_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/chrome_sync_client_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/migration_waiter.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/multi_client_status_change_checker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/passwords_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_integration_test_util.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync/driver/generic_change_processor_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/driver/model_type_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/driver/model_type_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/engine/attachments/on_disk_attachment_store.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/engine/cycle/sync_cycle_snapshot_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_connection_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server_entity.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_bookmark_entity.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_permanent_entity.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_tombstone_entity.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M components/sync/engine_impl/sync_manager_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/engine_impl/test_entry_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
phoglund_chromium
Created Revert of [Sync] IWYU cleanup.
4 years, 1 month ago (2016-10-31 10:27:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466463002/1
4 years, 1 month ago (2016-10-31 10:27:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 11:14:13 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 11:16:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8d55b3d552a5d23c8c71da157c2f4bbdab56130
Cr-Commit-Position: refs/heads/master@{#428685}

Powered by Google App Engine
This is Rietveld 408576698