Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2466453003: Fix nullptr access in CursorRendererAura::SnapshotCursorState. (Closed)

Created:
4 years, 1 month ago by krasin1
Modified:
4 years, 1 month ago
Reviewers:
Wez
CC:
chromium-reviews, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix nullptr access in CursorRendererAura::SnapshotCursorState. If active_window is nil, we should not call virtual methods on it. The bug was found by running content_unittests under UBSan. BUG=607996 Committed: https://crrev.com/25c64861843f487feedf6eaa76acbec96187bb68 Cr-Commit-Position: refs/heads/master@{#428863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/media/capture/cursor_renderer_aura.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
krasin1
4 years, 1 month ago (2016-10-31 21:55:00 UTC) #3
Wez
lgtm
4 years, 1 month ago (2016-10-31 23:23:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466453003/1
4 years, 1 month ago (2016-10-31 23:24:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 23:29:38 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 23:31:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25c64861843f487feedf6eaa76acbec96187bb68
Cr-Commit-Position: refs/heads/master@{#428863}

Powered by Google App Engine
This is Rietveld 408576698