Add mojo::edk::ClosePeerConnection.

Add mojo::edk::ClosePeerConnection.

Remoting needs to run an IPC server on a well-known named pipe to
support remote security key requests. However, this server should only
accept connections while a remote desktop session is active and any
previous peer process connections awaiting a connection should be
closed. This CL adds a mojo embedder API to close a peer connection to
support this use case.

BUG=604282
Committed: https://crrev.com/e0ba60e6c1734b2da106eefb2b8926373cd7e527
Cr-Commit-Position: refs/heads/master@{#429710}

[Sam McNally, 2016-10-31 05:54:46]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 05:55:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 06:04:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 06:04:12]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Sam McNally, 2016-10-31 06:10:52]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 06:11:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 07:31:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 07:31:30]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-10-31 08:55:06]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 08:55:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-10-31 08:56:22]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-10-31 09:49:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 09:49:13]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-10-31 10:06:38]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[Sam McNally, 2016-10-31 10:06:47]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2016-10-31 10:06:50]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-10-31 10:06:52]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-10-31 10:06:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 11:01:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 11:01:33]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-11-01 03:49:36]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 03:49:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 03:58:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 03:58:09]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Sam McNally, 2016-11-01 05:55:15]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 05:55:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-01 06:37:22]

Patchset #1 (id:80001) has been deleted

[Sam McNally, 2016-11-01 06:37:31]

Patchset #1 (id:100001) has been deleted

[Sam McNally, 2016-11-01 06:43:43]

Description was changed from

==========
Add mojo::edk::ClosePeerConnection.

Remoting needs to run an IPC server on a well-known named pipe to
support remote security key requests. However, this server should only
accept connections while a remote desktop session is active and any
previous peer process connections awaiting a connection should be
closed. This CL adds a mojo embedder to close a peer connection to
support this use case.

BUG=604282
==========

to

==========
Add mojo::edk::ClosePeerConnection.

Remoting needs to run an IPC server on a well-known named pipe to
support remote security key requests. However, this server should only
accept connections while a remote desktop session is active and any
previous peer process connections awaiting a connection should be
closed. This CL adds a mojo embedder API to close a peer connection to
support this use case.

BUG=604282
==========

[commit-bot: I haz the power, 2016-11-01 07:02:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 07:02:18]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-11-03 00:40:18]

sammc@chromium.org changed reviewers:
+ rockot@chromium.org

[Sam McNally, 2016-11-03 00:40:18]

This was the previous, less-hacky approach for closing pending mojo peer
connections.

As far as I can tell, the options for doing what remoting needs are:
1. This CL, with remoting using it to stop listening for a connection when it
needs to.
2. Have the server make a client connection to itself to consume the pending
connection accept.
3. Add an embedder API for running a server on a named pipe/listen socket that
returns a message pipe for each connection, along with a way to stop accepting
new connections. This would enable simplifying how service process and app shim
connections are handled, which would be nice, but it feels like a lot of API
surface for a fairly niche use case.

WDYT?

[Ken Rockot(use gerrit already), 2016-11-03 05:02:52]

LGTM

#3 seems like the most elegant solution in isolation, but I agree it may be API
overkill. This CL seems OK to me as-is.

https://codereview.chromium.org/2466433002/diff/120001/mojo/edk/embedder/embe...
File mojo/edk/embedder/embedder_unittest.cc (right):

https://codereview.chromium.org/2466433002/diff/120001/mojo/edk/embedder/embe...
mojo/edk/embedder/embedder_unittest.cc:589: for (size_t i = 0; i < 10; i++) {
This seems destined to be flaky. Can we not do this?

[Sam McNally, 2016-11-03 06:19:24]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 06:19:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-03 07:13:36]

https://codereview.chromium.org/2466433002/diff/120001/mojo/edk/embedder/embe...
File mojo/edk/embedder/embedder_unittest.cc (right):

https://codereview.chromium.org/2466433002/diff/120001/mojo/edk/embedder/embe...
mojo/edk/embedder/embedder_unittest.cc:589: for (size_t i = 0; i < 10; i++) {
On 2016/11/03 05:02:52, Ken Rockot wrote:
> This seems destined to be flaky. Can we not do this?

Done.

[Sam McNally, 2016-11-03 07:14:11]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-11-03 07:14:11]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2466433002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-11-03 07:14:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 08:20:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 08:20:11]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Sam McNally, 2016-11-03 08:31:45]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-11-03 08:32:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 10:32:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 10:32:37]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Sam McNally, 2016-11-03 22:02:53]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:03:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 22:15:03]

Committed patchset #2 (id:140001)

[commit-bot: I haz the power, 2016-11-03 22:18:44]

Description was changed from

==========
Add mojo::edk::ClosePeerConnection.

Remoting needs to run an IPC server on a well-known named pipe to
support remote security key requests. However, this server should only
accept connections while a remote desktop session is active and any
previous peer process connections awaiting a connection should be
closed. This CL adds a mojo embedder API to close a peer connection to
support this use case.

BUG=604282
==========

to

==========
Add mojo::edk::ClosePeerConnection.

Remoting needs to run an IPC server on a well-known named pipe to
support remote security key requests. However, this server should only
accept connections while a remote desktop session is active and any
previous peer process connections awaiting a connection should be
closed. This CL adds a mojo embedder API to close a peer connection to
support this use case.

BUG=604282

Committed: https://crrev.com/e0ba60e6c1734b2da106eefb2b8926373cd7e527
Cr-Commit-Position: refs/heads/master@{#429710}
==========

[commit-bot: I haz the power, 2016-11-03 22:18:45]

Patchset 2 (id:??) landed as
https://crrev.com/e0ba60e6c1734b2da106eefb2b8926373cd7e527
Cr-Commit-Position: refs/heads/master@{#429710}