CodeStubs contain their corresponding Isolate* now. (part 1)

CodeStubs contain their corresponding Isolate* now. (part 1)

This is a purely mechanical change, adding an Isolate* to the CodeStub
constructor and a corresponding field plus a getter. A few methods in
CodeStub and its subclasses can be simplified now, but this is done in
a separate CL.

The underlying reason apart from simplicity is that deep down in the
call chain we need to detect if the serializer is active or not. This
information will be part of the Isolate, not a global variable with
funky synchronization primitives around it (which is fundamentally
wrong and the underlying cause for race conditions and a catch-22
during initialization).

BUG=359977
LOG=y
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20919

[Sven Panne, 2014-04-23 13:16:00]

Long and boring, but mechanical... :-)

[Michael Starzinger, 2014-04-23 13:58:21]

LGTM, just nits.

https://codereview.chromium.org/246643014/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (left):

https://codereview.chromium.org/246643014/diff/1/src/arm/code-stubs-arm.cc#ol...
src/arm/code-stubs-arm.cc:3787: 
nit: Can we get the empty newline back for readability?

https://codereview.chromium.org/246643014/diff/1/src/arm64/code-stubs-arm64.cc
File src/arm64/code-stubs-arm64.cc (left):

https://codereview.chromium.org/246643014/diff/1/src/arm64/code-stubs-arm64.c...
src/arm64/code-stubs-arm64.cc:4318: 
nit: Can we get the empty newline back for readability?

https://codereview.chromium.org/246643014/diff/1/src/arm64/code-stubs-arm64.cc
File src/arm64/code-stubs-arm64.cc (right):

https://codereview.chromium.org/246643014/diff/1/src/arm64/code-stubs-arm64.c...
src/arm64/code-stubs-arm64.cc:5223: Handle<Object>
undefined_sentinel(isolate()->heap()->undefined_value(),
nit: I know it's not part of your change, but can we use the following instead?

Handle<Object> undefined_sentinel = isolate()->factory()->undefined_value();

https://codereview.chromium.org/246643014/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (left):

https://codereview.chromium.org/246643014/diff/1/src/ia32/code-stubs-ia32.cc#...
src/ia32/code-stubs-ia32.cc:3669: 
nit: Can we get the empty newline back for readability?

https://codereview.chromium.org/246643014/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (left):

https://codereview.chromium.org/246643014/diff/1/src/x64/code-stubs-x64.cc#ol...
src/x64/code-stubs-x64.cc:3556: 
nit: Can we get the empty newline back for readability?

[Sven Panne, 2014-04-24 06:05:34]

Addressed comments, landing...

https://codereview.chromium.org/246643014/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (left):

https://codereview.chromium.org/246643014/diff/1/src/arm/code-stubs-arm.cc#ol...
src/arm/code-stubs-arm.cc:3787: 
On 2014/04/23 13:58:21, Michael Starzinger wrote:
> nit: Can we get the empty newline back for readability?

Done.

https://codereview.chromium.org/246643014/diff/1/src/arm64/code-stubs-arm64.cc
File src/arm64/code-stubs-arm64.cc (left):

https://codereview.chromium.org/246643014/diff/1/src/arm64/code-stubs-arm64.c...
src/arm64/code-stubs-arm64.cc:4318: 
On 2014/04/23 13:58:21, Michael Starzinger wrote:
> nit: Can we get the empty newline back for readability?

Done.

https://codereview.chromium.org/246643014/diff/1/src/arm64/code-stubs-arm64.cc
File src/arm64/code-stubs-arm64.cc (right):

https://codereview.chromium.org/246643014/diff/1/src/arm64/code-stubs-arm64.c...
src/arm64/code-stubs-arm64.cc:5223: Handle<Object>
undefined_sentinel(isolate()->heap()->undefined_value(),
On 2014/04/23 13:58:21, Michael Starzinger wrote:
> nit: I know it's not part of your change, but can we use the following
instead?
> 
> Handle<Object> undefined_sentinel = isolate()->factory()->undefined_value();

Done.

https://codereview.chromium.org/246643014/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (left):

https://codereview.chromium.org/246643014/diff/1/src/ia32/code-stubs-ia32.cc#...
src/ia32/code-stubs-ia32.cc:3669: 
On 2014/04/23 13:58:21, Michael Starzinger wrote:
> nit: Can we get the empty newline back for readability?

Done.

https://codereview.chromium.org/246643014/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (left):

https://codereview.chromium.org/246643014/diff/1/src/x64/code-stubs-x64.cc#ol...
src/x64/code-stubs-x64.cc:3556: 
On 2014/04/23 13:58:21, Michael Starzinger wrote:
> nit: Can we get the empty newline back for readability?

Done.

[Sven Panne, 2014-04-24 06:26:12]

Committed patchset #2 manually as r20919 (presubmit successful).