Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2466413007: [Devtools] Moved new timeline canvas context menu to bottom (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
index 76c886b23dc232c3b835c6a4f1794287ad3a0cc1..2b47d4dec92f9d9dba8337b657ef7482eb785e0f 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
@@ -492,7 +492,26 @@ WebInspector.NetworkLogViewColumns = class {
* @param {!WebInspector.ContextMenu} contextMenu
*/
_innerHeaderContextMenu(contextMenu) {
+ var columnConfigs = this._columns.filter(columnConfig => columnConfig.hideable);
+ var nonResponseHeaders = columnConfigs.filter(columnConfig => !columnConfig.isResponseHeader);
+ for (var columnConfig of nonResponseHeaders)
+ contextMenu.appendCheckboxItem(
+ columnConfig.title, this._toggleColumnVisibility.bind(this, columnConfig), columnConfig.visible);
+
+ contextMenu.appendSeparator();
+
+ var responseSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString('Response Headers'));
+ var responseHeaders = columnConfigs.filter(columnConfig => columnConfig.isResponseHeader);
+ for (var columnConfig of responseHeaders)
+ responseSubMenu.appendCheckboxItem(
+ columnConfig.title, this._toggleColumnVisibility.bind(this, columnConfig), columnConfig.visible);
+
+ responseSubMenu.appendSeparator();
+ responseSubMenu.appendItem(
+ WebInspector.UIString('Manage Header Columns\u2026'), this._manageCustomHeaderDialog.bind(this));
+
if (Runtime.experiments.isEnabled('canvasNetworkTimeline')) {
+ contextMenu.appendSeparator();
var timelineSortIds = WebInspector.NetworkLogViewColumns.TimelineSortIds;
var timelineSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString('Timeline'));
timelineSubMenu.appendCheckboxItem(
@@ -510,25 +529,7 @@ WebInspector.NetworkLogViewColumns = class {
timelineSubMenu.appendCheckboxItem(
WebInspector.UIString('Latency'), setTimelineMode.bind(this, timelineSortIds.Latency),
this._activeTimelineSortId === timelineSortIds.Latency);
- contextMenu.appendSeparator();
}
- var columnConfigs = this._columns.filter(columnConfig => columnConfig.hideable);
- var nonResponseHeaders = columnConfigs.filter(columnConfig => !columnConfig.isResponseHeader);
- for (var columnConfig of nonResponseHeaders)
- contextMenu.appendCheckboxItem(
- columnConfig.title, this._toggleColumnVisibility.bind(this, columnConfig), columnConfig.visible);
-
- contextMenu.appendSeparator();
-
- var responseSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString('Response Headers'));
- var responseHeaders = columnConfigs.filter(columnConfig => columnConfig.isResponseHeader);
- for (var columnConfig of responseHeaders)
- responseSubMenu.appendCheckboxItem(
- columnConfig.title, this._toggleColumnVisibility.bind(this, columnConfig), columnConfig.visible);
-
- responseSubMenu.appendSeparator();
- responseSubMenu.appendItem(
- WebInspector.UIString('Manage Header Columns\u2026'), this._manageCustomHeaderDialog.bind(this));
contextMenu.show();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698