Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1853)

Issue 2466413007: [Devtools] Moved new timeline canvas context menu to bottom (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
paulirish, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Moved new timeline canvas context menu to bottom Moved the context menu item for timeline to bottom of context menu instead of top per paulirish@. R=dgozman,paulirish BUG=653738 Committed: https://crrev.com/c1d8671b5708aa90dde46133d85d75f4c17aedbd Cr-Commit-Position: refs/heads/master@{#429802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 2 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
allada
PTL
4 years, 1 month ago (2016-11-03 20:45:57 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-11-03 22:31:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466413007/1
4 years, 1 month ago (2016-11-03 22:34:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/325056)
4 years, 1 month ago (2016-11-04 02:14:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466413007/1
4 years, 1 month ago (2016-11-04 04:25:28 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 05:54:40 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 05:56:42 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1d8671b5708aa90dde46133d85d75f4c17aedbd
Cr-Commit-Position: refs/heads/master@{#429802}

Powered by Google App Engine
This is Rietveld 408576698