Type check untyped == calls specially.

Type check untyped == calls specially.

A comparison of form x == null does not need an interface target, but
should still have a return type of 'bool'.

BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/kernel/commit/6074a67dcbd5f506b70d8ac4dac1f06348a70b6e

[asgerf, 2016-11-01 15:21:35]

asgerf@google.com changed reviewers:
+ kmillikin@google.com

[ahe, 2016-11-01 16:52:23]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2016-11-01 16:52:24]

https://codereview.chromium.org/2466373002/diff/1/lib/type_checker.dart
File lib/type_checker.dart (right):

https://codereview.chromium.org/2466373002/diff/1/lib/type_checker.dart#newco...
lib/type_checker.dart:466: return environment.boolType;
I don't see how you know that you can return bool here. How do you know that the
argument is null or the receiver is null?

[asgerf, 2016-11-01 17:07:33]

https://codereview.chromium.org/2466373002/diff/1/lib/type_checker.dart
File lib/type_checker.dart (right):

https://codereview.chromium.org/2466373002/diff/1/lib/type_checker.dart#newco...
lib/type_checker.dart:466: return environment.boolType;
On 2016/11/01 16:52:24, ahe wrote:
> I don't see how you know that you can return bool here. How do you know that
the
> argument is null or the receiver is null?

In strong mode (which is what we are checking), operator== must return bool
because it overrides Object.==

[Kevin Millikin (Google), 2016-11-02 07:06:56]

LGTM.

[asgerf, 2016-11-02 08:59:28]

Description was changed from

==========
Type check untyped == calls specially.

A comparison of form x == null does not need an interface target, but
should still have a return type of 'bool'.

BUG=
==========

to

==========
Type check untyped == calls specially.

A comparison of form x == null does not need an interface target, but
should still have a return type of 'bool'.

BUG=
R=kmillikin@google.com

Committed:
https://github.com/dart-lang/kernel/commit/6074a67dcbd5f506b70d8ac4dac1f06348...
==========

[asgerf, 2016-11-02 08:59:30]

Committed patchset #1 (id:1) manually as
6074a67dcbd5f506b70d8ac4dac1f06348a70b6e (presubmit successful).