Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2466363003: Allow Platform.executable for JIT app snapshots. (Closed)

Created:
4 years, 1 month ago by rmacnak
Modified:
4 years, 1 month ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow Platform.executable for JIT app snapshots. Because they run on a VM that can also run from source, they don't have the same fork-bomb problem we have when running with AOT. Related to #26417 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/0c3773fd71bda9de4b715f668f8aea8d683f939d

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -60 lines) Patch
M runtime/bin/platform.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +1 line, -11 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/standalone/http_launch_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/standalone/io/addlatexhash_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_blocking_lock_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/io/file_lock_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/io/file_read_special_device_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/io/file_test.dart View 17 chunks +24 lines, -20 lines 0 comments Download
M tests/standalone/io/http_client_stays_alive_test.dart View 2 chunks +5 lines, -1 line 0 comments Download
M tests/standalone/io/http_server_close_response_after_error_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/https_unauthorized_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M tests/standalone/io/print_sync_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/io/process_detached_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/standalone/io/process_set_exit_code_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/standalone/io/process_shell_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/standalone/io/process_sync_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/io/regress_7191_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_unauthorized_test.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M tests/standalone/io/signals_test.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/skipping_dart2js_compilations_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/io/stdin_sync_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/io/stdio_implicit_close_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/io/stdio_nonblocking_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +1 line, -1 line 0 comments Download
A + tests/standalone/verbose_gc_to_bmu_script.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/standalone/verbose_gc_to_bmu_test.dart View 1 3 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
rmacnak
4 years, 1 month ago (2016-11-01 19:24:49 UTC) #4
siva
lgtm
4 years, 1 month ago (2016-11-02 22:48:46 UTC) #5
rmacnak
4 years, 1 month ago (2016-11-02 23:28:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
0c3773fd71bda9de4b715f668f8aea8d683f939d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698