Replace all use of cricket::VideoFrame and cricket::WebRtcVideoFrame with webrtc::VideoFrame.

Replace all use of cricket::VideoFrame and cricket::WebRtcVideoFrame with webrtc::VideoFrame.

These classes are deprecated in webrtc.

BUG=webrtc:5682
Committed: https://crrev.com/19adfcc2077f9ac553397a34fbda8e46e25606b9
Cr-Commit-Position: refs/heads/master@{#430257}

[nisse-chromium (ooo August 14), 2016-11-02 11:54:26]

nisse@chromium.org changed reviewers:
+ sergeyu@chromium.org

[nisse-chromium (ooo August 14), 2016-11-02 11:54:27]

PTAL. Blocks relanding of cl https://codereview.webrtc.org/2471783002/

[Sergey Ulanov, 2016-11-02 19:33:59]

lgtm

https://codereview.chromium.org/2466353003/diff/20001/content/renderer/media/...
File content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc (right):

https://codereview.chromium.org/2466353003/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc:24: // #include
"third_party/webrtc/video_frame.h"
Why is this commented?

https://codereview.chromium.org/2466353003/diff/20001/content/renderer/media/...
File content/renderer/media/webrtc/webrtc_video_capturer_adapter_unittest.cc
(right):

https://codereview.chromium.org/2466353003/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/webrtc_video_capturer_adapter_unittest.cc:91: //
TODO(nisse): Default constructor is deprecated. Use std::optional?
std::optional is C++17. But this code could use base::Optional<> or allocate
output_frame_ dynamically (i.e. std::unique_ptr<>)

[nisse-chromium (ooo August 14), 2016-11-07 09:58:20]

https://codereview.chromium.org/2466353003/diff/20001/content/renderer/media/...
File content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc (right):

https://codereview.chromium.org/2466353003/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc:24: // #include
"third_party/webrtc/video_frame.h"
On 2016/11/02 19:33:59, Sergey Ulanov wrote:
> Why is this commented?

Ooops, it's a left over. I'll delete this line.

https://codereview.chromium.org/2466353003/diff/20001/content/renderer/media/...
File content/renderer/media/webrtc/webrtc_video_capturer_adapter_unittest.cc
(right):

https://codereview.chromium.org/2466353003/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/webrtc_video_capturer_adapter_unittest.cc:91: //
TODO(nisse): Default constructor is deprecated. Use std::optional?
On 2016/11/02 19:33:59, Sergey Ulanov wrote:
> std::optional is C++17. But this code could use base::Optional<> or allocate
> output_frame_ dynamically (i.e. std::unique_ptr<>)

I figured there's something similar to std::Optional in Chrome. Webrtc also has
it's own rtc::Optional.

[nisse-chromium (ooo August 14), 2016-11-07 11:58:41]

The CQ bit was checked by nisse@chromium.org

[nisse-chromium (ooo August 14), 2016-11-07 11:58:42]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2466353003/#ps40001
(title: "Drop unneeded include.")

[commit-bot: I haz the power, 2016-11-07 11:58:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 12:38:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-07 12:40:44]

Description was changed from

==========
Replace all use of cricket::VideoFrame and cricket::WebRtcVideoFrame with
webrtc::VideoFrame.

These classes are deprecated in webrtc.

BUG=webrtc:5682
==========

to

==========
Replace all use of cricket::VideoFrame and cricket::WebRtcVideoFrame with
webrtc::VideoFrame.

These classes are deprecated in webrtc.

BUG=webrtc:5682

Committed: https://crrev.com/19adfcc2077f9ac553397a34fbda8e46e25606b9
Cr-Commit-Position: refs/heads/master@{#430257}
==========

[commit-bot: I haz the power, 2016-11-07 12:40:45]

Patchset 3 (id:??) landed as
https://crrev.com/19adfcc2077f9ac553397a34fbda8e46e25606b9
Cr-Commit-Position: refs/heads/master@{#430257}