Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Issue 2466343002: Reland of Some more pre-material cleanups (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, tfarina, James Su, mac-reviews_chromium.org, please use gerrit instead
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Some more pre-material cleanups (patchset #1 id:1 of https://codereview.chromium.org/2464063002/ ) Reason for revert: Relanding as newer builds experienced the same flakiness: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8533 Original issue's description: > Revert of Some more pre-material cleanups (patchset #4 id:60001 of https://codereview.chromium.org/2444923003/ ) > > Reason for revert: > Speculative revert since being the only commit in the first of a long series of flaky failures in interactive_ui_tests on Mac10.10 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8428 > > Original issue's description: > > Some more pre-material cleanups > > > > BUG=648281 > > > > Committed: https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086 > > Cr-Commit-Position: refs/heads/master@{#428603} > > TBR=groby@chromium.org,pkasting@chromium.org,sadrul@chromium.org,estade@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=648281 > > Committed: https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a > Cr-Commit-Position: refs/heads/master@{#428969} TBR=groby@chromium.org,pkasting@chromium.org,sadrul@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=648281 Committed: https://crrev.com/f50a032e6a78c038902b0d83fa8e79ad2274ed87 Cr-Commit-Position: refs/heads/master@{#428990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -143 lines) Patch
M chrome/browser/ui/cocoa/infobars/infobar_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/infobar_container_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/infobar_container_delegate.cc View 4 chunks +11 lines, -51 lines 0 comments Download
M chrome/browser/ui/layout_constants.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/layout_constants.cc View 4 chunks +33 lines, -41 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar.cc View 3 chunks +7 lines, -27 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ui/base/material_design/material_design_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_chromium
Created Reland of Some more pre-material cleanups
4 years, 1 month ago (2016-11-01 13:30:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466343002/1
4 years, 1 month ago (2016-11-01 13:30:28 UTC) #3
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 1 month ago (2016-11-01 13:32:32 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 13:34:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f50a032e6a78c038902b0d83fa8e79ad2274ed87
Cr-Commit-Position: refs/heads/master@{#428990}

Powered by Google App Engine
This is Rietveld 408576698