Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: components/sync/driver/glue/browser_thread_model_worker.h

Issue 2466313003: Remove ModelSafeWorker::work_done_or_stopped(). (Closed)
Patch Set: self-review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SYNC_DRIVER_GLUE_BROWSER_THREAD_MODEL_WORKER_H_ 5 #ifndef COMPONENTS_SYNC_DRIVER_GLUE_BROWSER_THREAD_MODEL_WORKER_H_
6 #define COMPONENTS_SYNC_DRIVER_GLUE_BROWSER_THREAD_MODEL_WORKER_H_ 6 #define COMPONENTS_SYNC_DRIVER_GLUE_BROWSER_THREAD_MODEL_WORKER_H_
7 7
8 #include "base/callback_forward.h" 8 #include "base/callback_forward.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "components/sync/base/syncer_error.h" 11 #include "components/sync/base/syncer_error.h"
12 #include "components/sync/engine/model_safe_worker.h" 12 #include "components/sync/engine/model_safe_worker.h"
13 #include "components/sync/engine/signal_event_on_delete.h"
13 14
14 namespace base { 15 namespace base {
15 class SingleThreadTaskRunner; 16 class SingleThreadTaskRunner;
16 class WaitableEvent; 17 class WaitableEvent;
17 } // namespace base 18 } // namespace base
18 19
19 namespace syncer { 20 namespace syncer {
20 21
21 // A ModelSafeWorker for models that accept requests from the 22 // A ModelSafeWorker for models that accept requests from the
22 // syncapi that need to be fulfilled on a browser thread, for example 23 // syncapi that need to be fulfilled on a browser thread, for example
23 // autofill on the DB thread. 24 // autofill on the DB thread.
24 // TODO(sync): Try to generalize other ModelWorkers (e.g. history, etc). 25 // TODO(sync): Try to generalize other ModelWorkers (e.g. history, etc).
25 class BrowserThreadModelWorker : public ModelSafeWorker { 26 class BrowserThreadModelWorker : public ModelSafeWorker {
26 public: 27 public:
27 BrowserThreadModelWorker( 28 BrowserThreadModelWorker(
28 const scoped_refptr<base::SingleThreadTaskRunner>& runner, 29 const scoped_refptr<base::SingleThreadTaskRunner>& runner,
29 ModelSafeGroup group, 30 ModelSafeGroup group,
30 WorkerLoopDestructionObserver* observer); 31 WorkerLoopDestructionObserver* observer);
31 32
32 // ModelSafeWorker implementation. Called on the sync thread. 33 // ModelSafeWorker implementation. Called on the sync thread.
33 void RegisterForLoopDestruction() override; 34 void RegisterForLoopDestruction() override;
34 ModelSafeGroup GetModelSafeGroup() override; 35 ModelSafeGroup GetModelSafeGroup() override;
35 36
36 protected: 37 protected:
37 ~BrowserThreadModelWorker() override; 38 ~BrowserThreadModelWorker() override;
38 39
39 SyncerError DoWorkAndWaitUntilDoneImpl(const WorkCallback& work) override; 40 SyncerError DoWorkAndWaitUntilDoneImpl(const WorkCallback& work) override;
40 41
41 // Marked pure virtual so subclasses have to override, but there is 42 void CallDoWorkAndSignalTask(
42 // an implementation that subclasses should use. This is so that 43 const WorkCallback& work,
43 // (subclass)::CallDoWorkAndSignalTask shows up in callstacks. 44 syncer::SignalEventOnDelete signal_event_on_delete,
44 virtual void CallDoWorkAndSignalTask(const WorkCallback& work, 45 SyncerError* error);
45 base::WaitableEvent* done,
46 SyncerError* error);
47 46
48 private: 47 private:
49 scoped_refptr<base::SingleThreadTaskRunner> runner_; 48 scoped_refptr<base::SingleThreadTaskRunner> runner_;
50 ModelSafeGroup group_; 49 ModelSafeGroup group_;
51 50
52 DISALLOW_COPY_AND_ASSIGN(BrowserThreadModelWorker); 51 DISALLOW_COPY_AND_ASSIGN(BrowserThreadModelWorker);
53 }; 52 };
54 53
55 } // namespace syncer 54 } // namespace syncer
56 55
57 #endif // COMPONENTS_SYNC_DRIVER_GLUE_BROWSER_THREAD_MODEL_WORKER_H_ 56 #endif // COMPONENTS_SYNC_DRIVER_GLUE_BROWSER_THREAD_MODEL_WORKER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698