Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: components/sync/driver/glue/browser_thread_model_worker.cc

Issue 2466313003: Remove ModelSafeWorker::work_done_or_stopped(). (Closed)
Patch Set: self-review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync/driver/glue/browser_thread_model_worker.h" 5 #include "components/sync/driver/glue/browser_thread_model_worker.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/single_thread_task_runner.h" 8 #include "base/single_thread_task_runner.h"
9 #include "base/synchronization/waitable_event.h" 9 #include "base/synchronization/waitable_event.h"
10 10
11 using base::SingleThreadTaskRunner; 11 using base::SingleThreadTaskRunner;
12 using base::WaitableEvent; 12 using base::WaitableEvent;
13 13
14 namespace syncer { 14 namespace syncer {
15 15
16 BrowserThreadModelWorker::BrowserThreadModelWorker( 16 BrowserThreadModelWorker::BrowserThreadModelWorker(
17 const scoped_refptr<SingleThreadTaskRunner>& runner, 17 const scoped_refptr<SingleThreadTaskRunner>& runner,
18 ModelSafeGroup group, 18 ModelSafeGroup group,
19 WorkerLoopDestructionObserver* observer) 19 WorkerLoopDestructionObserver* observer)
20 : ModelSafeWorker(observer), runner_(runner), group_(group) {} 20 : ModelSafeWorker(observer), runner_(runner), group_(group) {}
21 21
22 SyncerError BrowserThreadModelWorker::DoWorkAndWaitUntilDoneImpl( 22 SyncerError BrowserThreadModelWorker::DoWorkAndWaitUntilDoneImpl(
23 const WorkCallback& work) { 23 const WorkCallback& work) {
24 SyncerError error = UNSET; 24 SyncerError error = UNSET;
25 if (runner_->BelongsToCurrentThread()) { 25 if (runner_->BelongsToCurrentThread()) {
26 DLOG(WARNING) << "Already on thread " << runner_; 26 DLOG(WARNING) << "Already on thread " << runner_;
27 return work.Run(); 27 return work.Run();
28 } 28 }
29 29
30 // Signaled when the task is deleted, i.e. after it runs or when it is
31 // abandonned.
32 base::WaitableEvent work_done_or_abandonned(
33 base::WaitableEvent::ResetPolicy::AUTOMATIC,
34 base::WaitableEvent::InitialState::NOT_SIGNALED);
35
30 if (!runner_->PostTask( 36 if (!runner_->PostTask(
31 FROM_HERE, 37 FROM_HERE,
32 base::Bind(&BrowserThreadModelWorker::CallDoWorkAndSignalTask, this, 38 base::Bind(&BrowserThreadModelWorker::CallDoWorkAndSignalTask, this,
33 work, work_done_or_stopped(), &error))) { 39 work, base::Passed(syncer::SignalEventOnDelete(
40 &work_done_or_abandonned)),
41 &error))) {
34 DLOG(WARNING) << "Failed to post task to runner " << runner_; 42 DLOG(WARNING) << "Failed to post task to runner " << runner_;
35 error = CANNOT_DO_WORK; 43 error = CANNOT_DO_WORK;
36 return error; 44 return error;
37 } 45 }
38 work_done_or_stopped()->Wait(); 46 work_done_or_abandonned.Wait();
39 return error; 47 return error;
40 } 48 }
41 49
42 ModelSafeGroup BrowserThreadModelWorker::GetModelSafeGroup() { 50 ModelSafeGroup BrowserThreadModelWorker::GetModelSafeGroup() {
43 return group_; 51 return group_;
44 } 52 }
45 53
46 BrowserThreadModelWorker::~BrowserThreadModelWorker() {} 54 BrowserThreadModelWorker::~BrowserThreadModelWorker() {}
47 55
48 void BrowserThreadModelWorker::RegisterForLoopDestruction() { 56 void BrowserThreadModelWorker::RegisterForLoopDestruction() {
49 if (runner_->BelongsToCurrentThread()) { 57 if (runner_->BelongsToCurrentThread()) {
50 SetWorkingLoopToCurrent(); 58 SetWorkingLoopToCurrent();
51 } else { 59 } else {
52 runner_->PostTask( 60 runner_->PostTask(
53 FROM_HERE, 61 FROM_HERE,
54 Bind(&BrowserThreadModelWorker::RegisterForLoopDestruction, this)); 62 Bind(&BrowserThreadModelWorker::RegisterForLoopDestruction, this));
55 } 63 }
56 } 64 }
57 65
58 void BrowserThreadModelWorker::CallDoWorkAndSignalTask(const WorkCallback& work, 66 void BrowserThreadModelWorker::CallDoWorkAndSignalTask(
59 WaitableEvent* done, 67 const WorkCallback& work,
60 SyncerError* error) { 68 syncer::SignalEventOnDelete signal_event_on_delete,
69 SyncerError* error) {
61 DCHECK(runner_->BelongsToCurrentThread()); 70 DCHECK(runner_->BelongsToCurrentThread());
62 if (!IsStopped()) 71 if (!IsStopped())
63 *error = work.Run(); 72 *error = work.Run();
64 done->Signal(); 73 // The event in |signal_event_on_delete| is signaled at the end of this scope.
65 } 74 }
66 75
67 } // namespace syncer 76 } // namespace syncer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698