Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2466273008: DevTools: Whitelist Runtime stats counters shown on timeline. (Closed)

Created:
4 years, 1 month ago by alph
Modified:
4 years, 1 month ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Whitelist Runtime stats counters shown on timeline. BUG=660428 Committed: https://crrev.com/088af6a68896feac07caec515de2efafa597c7c6 Cr-Commit-Position: refs/heads/master@{#429521}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comment + rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -19 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js View 1 4 chunks +33 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
alph
4 years, 1 month ago (2016-11-02 22:50:47 UTC) #2
caseq
lgtm https://codereview.chromium.org/2466273008/diff/1/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js File third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js (right): https://codereview.chromium.org/2466273008/diff/1/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js#newcode170 third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js:170: if (showRuntimeCallStats && url === 'native V8Runtime' && ...
4 years, 1 month ago (2016-11-02 23:35:09 UTC) #3
alph
https://codereview.chromium.org/2466273008/diff/1/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js File third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js (right): https://codereview.chromium.org/2466273008/diff/1/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js#newcode170 third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js:170: if (showRuntimeCallStats && url === 'native V8Runtime' && !visibleV8RuntimeStatsItems.has(frame.functionName)) ...
4 years, 1 month ago (2016-11-03 01:10:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466273008/20001
4 years, 1 month ago (2016-11-03 01:11:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 03:55:41 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 03:57:52 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/088af6a68896feac07caec515de2efafa597c7c6
Cr-Commit-Position: refs/heads/master@{#429521}

Powered by Google App Engine
This is Rietveld 408576698