[debugger] Further stepping support in test wrapper

[debugger] Further stepping support in test wrapper

This CL adds further support to the test wrapper. We are now able to
run almost all mjsunit/debug-step-* tests using the inspector backend.

debug-stepframe-* tests are not yet supported since inspector does not
know a 'frame' step type.

The interface has also been improved to be able to move these tests to
inspector mostly without modification.

BUG=v8:5330
Committed: https://crrev.com/ea48d0942a2a12203cce9459856f6f0c02e5c2df
Cr-Commit-Position: refs/heads/master@{#40800}

[jgruber, 2016-11-02 08:04:07]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 08:04:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 08:05:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 08:05:42]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/15495)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/15460)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/11781)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/27648)

[jgruber, 2016-11-02 08:13:09]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 08:13:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 08:37:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 08:37:11]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-11-02 08:47:38]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2016-11-02 08:47:39]

Some more work on the debug wrapper. This moves most stepping tests to the
inspector protocol. The wrapper API has been adapted to allow moving tests with
fewer manual changes.

We should probably discuss a couple of tests.

* d-s-scope-partX are slow and do not really test anything now that scopeType()
and scopeObject don't contain any logic themselves. I guess we can probably
remove these.

* d-s-turbofan is marked as [PASS, FAIL] in all modes. How close are we to
fixing this? It's only missing a single step on function exit. We should at
least mark this as failing in turbofan modes only.

* d-s-construct-call: not sure if this one was testing the right thing since it
passed a BreakPositionAlignment arg to setBreakpoint (which does not seem to
expect a BPA).

[Yang, 2016-11-02 10:36:04]

lgtm. awesome!

https://codereview.chromium.org/2466273005/diff/20001/test/debugger/test-api.js
File test/debugger/test-api.js (right):

https://codereview.chromium.org/2466273005/diff/20001/test/debugger/test-api....
test/debugger/test-api.js:173: delete this.receivedMessages[msgid];
I don't think this is how to use a Map. You would use the methods
Map.prototype.{set,get,delete}.

https://codereview.chromium.org/2466273005/diff/20001/test/debugger/test-api....
test/debugger/test-api.js:189: , scopeObject: () => scope.object
Can we have the comma on the previous line? Elsewhere too.

https://codereview.chromium.org/2466273005/diff/20001/test/debugger/test-api....
test/debugger/test-api.js:228: , frameCount : () => params.callFrames.length
80-char limit.

[jgruber, 2016-11-07 11:34:04]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 11:34:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-11-07 11:35:11]

https://codereview.chromium.org/2466273005/diff/20001/test/debugger/test-api.js
File test/debugger/test-api.js (right):

https://codereview.chromium.org/2466273005/diff/20001/test/debugger/test-api....
test/debugger/test-api.js:173: delete this.receivedMessages[msgid];
On 2016/11/02 10:36:04, Yang wrote:
> I don't think this is how to use a Map. You would use the methods
> Map.prototype.{set,get,delete}.

Done.

https://codereview.chromium.org/2466273005/diff/20001/test/debugger/test-api....
test/debugger/test-api.js:189: , scopeObject: () => scope.object
On 2016/11/02 10:36:04, Yang wrote:
> Can we have the comma on the previous line? Elsewhere too.

Dang, thought I could sneak some nice haskell-style list formatting in. Done.

https://codereview.chromium.org/2466273005/diff/20001/test/debugger/test-api....
test/debugger/test-api.js:228: , frameCount : () => params.callFrames.length
On 2016/11/02 10:36:04, Yang wrote:
> 80-char limit.

Done.

[Yang, 2016-11-07 11:38:25]

On 2016/11/07 11:35:11, jgruber wrote:
>
https://codereview.chromium.org/2466273005/diff/20001/test/debugger/test-api.js
> File test/debugger/test-api.js (right):
> 
>
https://codereview.chromium.org/2466273005/diff/20001/test/debugger/test-api....
> test/debugger/test-api.js:173: delete this.receivedMessages[msgid];
> On 2016/11/02 10:36:04, Yang wrote:
> > I don't think this is how to use a Map. You would use the methods
> > Map.prototype.{set,get,delete}.
> 
> Done.
> 
>
https://codereview.chromium.org/2466273005/diff/20001/test/debugger/test-api....
> test/debugger/test-api.js:189: , scopeObject: () => scope.object
> On 2016/11/02 10:36:04, Yang wrote:
> > Can we have the comma on the previous line? Elsewhere too.
> 
> Dang, thought I could sneak some nice haskell-style list formatting in. Done.
> 
>
https://codereview.chromium.org/2466273005/diff/20001/test/debugger/test-api....
> test/debugger/test-api.js:228: , frameCount : () => params.callFrames.length
> On 2016/11/02 10:36:04, Yang wrote:
> > 80-char limit.
> 
> Done.

lgtm.

[commit-bot: I haz the power, 2016-11-07 11:57:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 11:57:38]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-11-07 12:00:28]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-11-07 12:00:29]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2466273005/#ps60001
(title: "Move more tests")

[commit-bot: I haz the power, 2016-11-07 12:00:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 12:24:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-17 22:24:31]

Description was changed from

==========
[debugger] Further stepping support in test wrapper

This CL adds further support to the test wrapper. We are now able to
run almost all mjsunit/debug-step-* tests using the inspector backend.

debug-stepframe-* tests are not yet supported since inspector does not
know a 'frame' step type.

The interface has also been improved to be able to move these tests to
inspector mostly without modification.

BUG=v8:5330
==========

to

==========
[debugger] Further stepping support in test wrapper

This CL adds further support to the test wrapper. We are now able to
run almost all mjsunit/debug-step-* tests using the inspector backend.

debug-stepframe-* tests are not yet supported since inspector does not
know a 'frame' step type.

The interface has also been improved to be able to move these tests to
inspector mostly without modification.

BUG=v8:5330

Committed: https://crrev.com/ea48d0942a2a12203cce9459856f6f0c02e5c2df
Cr-Commit-Position: refs/heads/master@{#40800}
==========

[commit-bot: I haz the power, 2016-11-17 22:24:33]

Patchset 4 (id:??) landed as
https://crrev.com/ea48d0942a2a12203cce9459856f6f0c02e5c2df
Cr-Commit-Position: refs/heads/master@{#40800}