Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2466273002: Revert of Support different Google attestation (Privacy CA) servers. (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, dkrahn+watch_chromium.org, dkalin1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support different Google attestation (Privacy CA) servers. (patchset #4 id:60001 of https://codereview.chromium.org/2448213007/ ) Reason for revert: Breaks unit_tests: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/builds/17343/steps/unit_tests%20on%20Ubuntu-12.04 Original issue's description: > Support different Google attestation (Privacy CA) servers. > > Add a --attestation-server flag that allows to pick the default or > the test server, and pass the appropriate value to cryptohomed > for operations involving requests sent to the attestation servers. > Also use the appropriate endpoints for the various servers when > sending requests. > > BUG=660260 > TEST=unit tests > > Committed: https://crrev.com/05374163a5a02f6768c72c1fe73c5f26723cb808 > Cr-Commit-Position: refs/heads/master@{#428869} TBR=apronin@chromium.org,dkrahn@chromium.org,mnissler@chromium.org,drcrash@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=660260 Committed: https://crrev.com/d0e8e3bb416bea73930344711a6197e63a68e063 Cr-Commit-Position: refs/heads/master@{#428957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -116 lines) Patch
M chrome/browser/chromeos/attestation/attestation_ca_client.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/attestation/attestation_ca_client.cc View 4 chunks +5 lines, -45 lines 0 comments Download
M chrome/browser/chromeos/attestation/attestation_ca_client_unittest.cc View 3 chunks +4 lines, -61 lines 0 comments Download
M chromeos/attestation/attestation_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_chromium
Created Revert of Support different Google attestation (Privacy CA) servers.
4 years, 1 month ago (2016-11-01 07:33:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466273002/1
4 years, 1 month ago (2016-11-01 07:33:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 07:34:46 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d0e8e3bb416bea73930344711a6197e63a68e063 Cr-Commit-Position: refs/heads/master@{#428957}
4 years, 1 month ago (2016-11-01 07:36:10 UTC) #6
The one and only Dr. Crash
4 years, 1 month ago (2016-11-01 20:36:41 UTC) #7
Message was sent while issue was closed.
Sorry about that.

On Tue, Nov 1, 2016 at 12:36 AM, commit-bot@chromium.org via
chromiumcodereview-hr.appspot.com <
reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/d0e8e3bb416bea73930344711a6197e63a68e063
> Cr-Commit-Position: refs/heads/master@{#428957}
>
> https://codereview.chromium.org/2466273002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698