Chromium Code Reviews
DescriptionRevert of [Mojo-Loading] Dispatch body data after response is received (patchset #2 id:20001 of https://codereview.chromium.org/2459483002/ )
Reason for revert:
Causing ASAN errors on WebKit Linux Precise Since
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20ASAN/builds/882
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Precise_ASAN/882/layout-test-results/results.html
errors like
virtual/mojo-loading/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html
==4==ERROR: AddressSanitizer: heap-use-after-free on address 0x60e0000b75d1 at pc 0x00000686e88c bp 0x7fffa32eeff0 sp 0x7fffa32eefe8
READ of size 1 at 0x60e0000b75d1 thread T0 (content_shell)
#0 0x686e88b in OnReadable content/child/url_response_body_consumer.cc:91:11
#1 0x46069ff in Run base/callback.h:64:12
#2 0x46069ff in OnHandleReady mojo/public/cpp/system/watcher.cc:122:0
#3 0x416c973 in Run base/callback.h:47:12
/* snip */
0x60e0000b75d1 is located 145 bytes inside of 152-byte region [0x60e0000b7540,0x60e0000b75d8)
freed by thread T0 (content_shell) here:
..
#8 0xc782b14 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2703:0
#9 0xc782b14 in OnReceivedData content/child/web_url_loader_impl.cc:988:0
#10 0x686e757 in OnReadable content/child/url_response_body_consumer.cc:113:25
#11 0x46069ff in Run base/callback.h:64:12
#12 0x46069ff in OnHandleReady mojo/public/cpp/system/watcher.cc:122:0
#13 0x416c973 in Run base/callback.h:47:12
/* snip */
Original issue's description:
> [Mojo-Loading] Dispatch body data after response is received
>
> MojoAsyncResourceHandler sometimes calls OnStartLoadingResponseBody
> before calling OnReceiveResponse. On the other hand, Blink doesn't
> expect onDataRecieved is called before onReceiveResponse.
>
> With this CL, URLLoaderClientImpl doesn't start reading the response body
> until OnReceivedResponse arrives.
>
> BUG=659917
>
> Committed: https://crrev.com/17be6599bb1c41d82b1193ab24ca0173cbe897be
> Cr-Commit-Position: refs/heads/master@{#429787}
TBR=tzik@chromium.org,jam@chromium.org,yhirano@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=659917
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||