Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2466263008: Revert of [Mojo-Loading] Dispatch body data after response is received (Closed)

Created:
4 years, 1 month ago by tapted
Modified:
4 years, 1 month ago
Reviewers:
jam, yhirano, tzik
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mojo-Loading] Dispatch body data after response is received (patchset #2 id:20001 of https://codereview.chromium.org/2459483002/ ) Reason for revert: Causing ASAN errors on WebKit Linux Precise Since https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20ASAN/builds/882 https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Precise_ASAN/882/layout-test-results/results.html errors like virtual/mojo-loading/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html ==4==ERROR: AddressSanitizer: heap-use-after-free on address 0x60e0000b75d1 at pc 0x00000686e88c bp 0x7fffa32eeff0 sp 0x7fffa32eefe8 READ of size 1 at 0x60e0000b75d1 thread T0 (content_shell) #0 0x686e88b in OnReadable content/child/url_response_body_consumer.cc:91:11 #1 0x46069ff in Run base/callback.h:64:12 #2 0x46069ff in OnHandleReady mojo/public/cpp/system/watcher.cc:122:0 #3 0x416c973 in Run base/callback.h:47:12 /* snip */ 0x60e0000b75d1 is located 145 bytes inside of 152-byte region [0x60e0000b7540,0x60e0000b75d8) freed by thread T0 (content_shell) here: .. #8 0xc782b14 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2703:0 #9 0xc782b14 in OnReceivedData content/child/web_url_loader_impl.cc:988:0 #10 0x686e757 in OnReadable content/child/url_response_body_consumer.cc:113:25 #11 0x46069ff in Run base/callback.h:64:12 #12 0x46069ff in OnHandleReady mojo/public/cpp/system/watcher.cc:122:0 #13 0x416c973 in Run base/callback.h:47:12 /* snip */ Original issue's description: > [Mojo-Loading] Dispatch body data after response is received > > MojoAsyncResourceHandler sometimes calls OnStartLoadingResponseBody > before calling OnReceiveResponse. On the other hand, Blink doesn't > expect onDataRecieved is called before onReceiveResponse. > > With this CL, URLLoaderClientImpl doesn't start reading the response body > until OnReceivedResponse arrives. > > BUG=659917 > > Committed: https://crrev.com/17be6599bb1c41d82b1193ab24ca0173cbe897be > Cr-Commit-Position: refs/heads/master@{#429787} TBR=tzik@chromium.org,jam@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=659917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M content/child/resource_dispatcher.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M content/child/url_response_body_consumer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/url_response_body_consumer.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M content/child/url_response_body_consumer_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tapted
Created Revert of [Mojo-Loading] Dispatch body data after response is received
4 years, 1 month ago (2016-11-04 08:32:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466263008/1
4 years, 1 month ago (2016-11-04 08:32:58 UTC) #3
yhirano
Maybe the CL you want to revert is https://codereview.chromium.org/2463753002/. Without that CL virtual/mojo-loading/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html would not ...
4 years, 1 month ago (2016-11-04 08:38:11 UTC) #5
tapted
4 years, 1 month ago (2016-11-04 08:42:22 UTC) #6
On 2016/11/04 08:38:11, yhirano wrote:
> Maybe the CL you want to revert is
https://codereview.chromium.org/2463753002/.
> Without that CL
>
virtual/mojo-loading/http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html
> would not run.

Ah! Thanks - yeah I thought it looked funny so I unticked commit and started
poking around some more. I'll revert that.

Powered by Google App Engine
This is Rietveld 408576698