[StyleGuide] Allow const in JavaScript code

catapult_build/js_checks.py

 # Copyright (c) 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 import eslint
 from py_vulcanize import strip_js_comments
 
 from catapult_build import parse_html
 
 
 class JSChecker(object):
 
   def __init__(self, input_api, output_api, file_filter=None):
     self.input_api = input_api
     self.output_api = output_api
     if file_filter:
       self.file_filter = file_filter
     else:
       self.file_filter = lambda x: True
 
-  def RegexCheck(self, line_number, line, regex, message):
-    """Searches for |regex| in |line| to check for a style violation.
-
-    The |regex| must have exactly one capturing group so that the relevant
-    part of |line| can be highlighted. If more groups are needed, use
-    "(?:...)" to make a non-capturing group. Sample message:
-
-    Returns a message like the one below if the regex matches.
-       line 6: Use var instead of const.
-           const foo = bar();
-           ^^^^^
-    """
-    match = re.search(regex, line)
-    if match:
-      assert len(match.groups()) == 1
-      start = match.start(1)
-      length = match.end(1) - start
-      return '  line %d: %s\n%s\n%s' % (
-          line_number,
-          message,
-          line,
-          _ErrorHighlight(start, length))
-    return ''
-
-  def ConstCheck(self, i, line):
-    """Checks for use of the 'const' keyword."""
-    if re.search(r'\*\s+@const', line):
-      # Probably a JsDoc line.
-      return ''
-
-    return self.RegexCheck(
-        i, line, r'(?:^|\s|\()(const)\s', 'Use var instead of const.')
-
   def RunChecks(self):
     """Checks for violations of the Chromium JavaScript style guide.
 
     See:
     http://chromium.org/developers/web-development-style-guide#TOC-JavaScript
     """
     results = []
 
     affected_files = self.input_api.AffectedFiles(
         file_filter=self.file_filter,
         include_deletes=False)
 
     def ShouldCheck(f):
       if f.LocalPath().endswith('.js'):
         return True
       if f.LocalPath().endswith('.html'):
         return True
       return False
 
     affected_js_files = filter(ShouldCheck, affected_files)
     error_lines = []
     for f in affected_js_files:
       contents = list(f.NewContents())
       error_lines += CheckStrictMode(
           '\n'.join(contents),
           is_html_file=f.LocalPath().endswith('.html'))
 
-      for i, line in enumerate(contents, start=1):
-        error_lines += filter(None, [self.ConstCheck(i, line)])
-
     if affected_js_files:
       success, eslint_output = eslint.RunEslint(
           [f.AbsoluteLocalPath() for f in affected_js_files])
 
       if not success:
         error_lines.append('\neslint found lint errors:')
         error_lines.append(eslint_output)
 
     if error_lines:
       error_lines.insert(0, 'Found JavaScript style violations:')
@@ skipping 44 matching lines @@
 
 def RunChecks(input_api, output_api, excluded_paths=None):
 
   def ShouldCheck(affected_file):
     if not excluded_paths:
       return True
     path = affected_file.LocalPath()
     return not any(re.match(pattern, path) for pattern in excluded_paths)
 
   return JSChecker(input_api, output_api, file_filter=ShouldCheck).RunChecks()