Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: third_party/WebKit/Source/core/paint/TableSectionPainter.cpp

Issue 2466253004: Don't paint repeating header if only the border spacing exceeds page height (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp b/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
index 829be97b402c4b56cad3cda5d6dddcfdaff03802..48605b78a95ae8568de71d17720b038739c1890c 100644
--- a/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
@@ -69,9 +69,9 @@ void TableSectionPainter::paintRepeatingHeaderGroup(
pageHeight)
.toInt());
}
- LayoutUnit bottomBound =
- std::min(LayoutUnit(paintInfo.cullRect().m_rect.maxY()),
- paintOffset.y() + table->logicalHeight());
+ LayoutUnit bottomBound = std::min(
+ LayoutUnit(paintInfo.cullRect().m_rect.maxY()),
+ paintOffset.y() + (table->logicalHeight() - table->vBorderSpacing()));
mstensho (USE GERRIT) 2016/11/01 20:41:32 What if it's only bottom captions that exceed the
paginationOffset.move(LayoutUnit(), -m_layoutTableSection.logicalTop());
while (paginationOffset.y() < bottomBound) {
LayoutPoint nestedOffset =

Powered by Google App Engine
This is Rietveld 408576698