Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2466243002: Add a UA style, "display: contents", for <slot> (Closed)

Created:
4 years, 1 month ago by hayato
Modified:
4 years, 1 month ago
Reviewers:
kochi, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a UA style, "display: contents", for <slot> The spec is: https://html.spec.whatwg.org/#flow-content-3 This rule is guarded by the same runtime flag for "display: contents". Unless the flag is enabled, the rule can not be effective because the parser does not consider it a valid rule. This change only affects slots in non-shadow trees since Blink excludes slots in shadow trees from a flat tree. Since "display: contents" is not well supported yet, the children of a slot in non-shadow trees would not be displayed. BUG=657748, 660265 Committed: https://crrev.com/d582fd6159457a8a9ff4f2064ce45d8bc4626c72 Cr-Commit-Position: refs/heads/master@{#429198}

Patch Set 1 #

Total comments: 2

Patch Set 2 : updatae #

Total comments: 3

Patch Set 3 : Use html.css #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/shadow-dom/slots.html View 2 chunks +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-in-document-tree.html View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-in-document-tree-expected.html View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/html.css View 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (19 generated)
hayato
PTAL
4 years, 1 month ago (2016-11-01 05:18:42 UTC) #7
kochi
I'm confused by the last line of the description: > the children of a slot ...
4 years, 1 month ago (2016-11-01 05:41:41 UTC) #8
hayato
updatae
4 years, 1 month ago (2016-11-01 05:45:07 UTC) #9
hayato
> When the experimental flag is turned on, any fallback slots > in non-shadow tree ...
4 years, 1 month ago (2016-11-01 05:46:33 UTC) #12
kochi
LGTM with nits For the subject and the first line of the description, "an UA ...
4 years, 1 month ago (2016-11-01 06:43:14 UTC) #13
rune
https://codereview.chromium.org/2466243002/diff/20001/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp File third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp (right): https://codereview.chromium.org/2466243002/diff/20001/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp#newcode165 third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp:165: !m_slotStyleSheet) { On 2016/11/01 06:43:13, kochi wrote: > If ...
4 years, 1 month ago (2016-11-01 07:38:17 UTC) #18
hayato
I have found that the current approach might not be good enough. Let me re-check ...
4 years, 1 month ago (2016-11-01 07:52:06 UTC) #19
hayato
Use html.css
4 years, 1 month ago (2016-11-02 02:24:58 UTC) #20
hayato
Thank you for the reviews. I have changed my mind. It looks that using slot.css ...
4 years, 1 month ago (2016-11-02 02:29:38 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466243002/40001
4 years, 1 month ago (2016-11-02 02:33:40 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-02 03:19:06 UTC) #29
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 03:22:07 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d582fd6159457a8a9ff4f2064ce45d8bc4626c72
Cr-Commit-Position: refs/heads/master@{#429198}

Powered by Google App Engine
This is Rietveld 408576698