Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 246623009: Added arm test spec. (Closed)

Created:
6 years, 8 months ago by nodir
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Added arm test spec. Will be used by chromium_trybot_arm recipe. R=mseaborn@chromium.org, phajdan.jr@chromium.org BUG=359338 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269655

Patch Set 1 #

Total comments: 2

Patch Set 2 : renamed the file to chromium_arm.json #

Total comments: 1

Patch Set 3 : added a description and removed trailing commands because json.load couldn't parse them #

Total comments: 2

Patch Set 4 : updated description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
A testing/buildbot/chromium_arm.json View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
nodir
6 years, 8 months ago (2014-04-23 19:24:55 UTC) #1
Paweł Hajdan Jr.
As said before, I don't recommend this solution. Why not just ensure that only tests ...
6 years, 8 months ago (2014-04-24 10:59:42 UTC) #2
Mark Seaborn
I thought the plan was to first get the ARM Chromium buildbots/trybots using isolate (which ...
6 years, 8 months ago (2014-04-24 15:22:44 UTC) #3
nodir
On 2014/04/24 10:59:42, Paweł Hajdan Jr. wrote: > As said before, I don't recommend this ...
6 years, 8 months ago (2014-04-24 17:18:24 UTC) #4
nodir
On 2014/04/24 15:22:44, Mark Seaborn wrote: > I thought the plan was to first get ...
6 years, 8 months ago (2014-04-24 17:21:58 UTC) #5
Mark Seaborn
On 2014/04/24 17:21:58, nodir wrote: > On 2014/04/24 15:22:44, Mark Seaborn wrote: > > I ...
6 years, 8 months ago (2014-04-24 21:56:27 UTC) #6
Paweł Hajdan Jr.
On 2014/04/24 17:18:24, nodir wrote: > On 2014/04/24 10:59:42, Paweł Hajdan Jr. wrote: > > ...
6 years, 8 months ago (2014-04-25 13:38:28 UTC) #7
Mark Seaborn
On 25 April 2014 06:38, <phajdan.jr@chromium.org> wrote: > On 2014/04/24 17:18:24, nodir wrote: > >> ...
6 years, 8 months ago (2014-04-25 15:51:11 UTC) #8
nodir
PTAL
6 years, 7 months ago (2014-05-09 02:32:00 UTC) #9
Mark Seaborn
LGTM https://codereview.chromium.org/246623009/diff/20001/testing/buildbot/chromium_arm.json File testing/buildbot/chromium_arm.json (right): https://codereview.chromium.org/246623009/diff/20001/testing/buildbot/chromium_arm.json#newcode4 testing/buildbot/chromium_arm.json:4: "args": "--gtest-filter='*NaCl*'", Can you add a comment saying ...
6 years, 7 months ago (2014-05-09 15:25:09 UTC) #10
nodir
The CQ bit was checked by nodir@chromium.org
6 years, 7 months ago (2014-05-09 21:18:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nodir@chromium.org/246623009/40001
6 years, 7 months ago (2014-05-09 21:22:31 UTC) #12
Mark Seaborn
https://codereview.chromium.org/246623009/diff/40001/testing/buildbot/chromium_arm.json File testing/buildbot/chromium_arm.json (right): https://codereview.chromium.org/246623009/diff/40001/testing/buildbot/chromium_arm.json#newcode3 testing/buildbot/chromium_arm.json:3: "description": ["These tests will be run on an ARM ...
6 years, 7 months ago (2014-05-09 21:26:31 UTC) #13
nodir
Done
6 years, 7 months ago (2014-05-09 21:36:22 UTC) #14
Mark Seaborn
BTW, to clarify, does this also turn off all test suites aside from browser_tests? There ...
6 years, 7 months ago (2014-05-09 22:05:46 UTC) #15
nodir
On 2014/05/09 22:05:46, Mark Seaborn wrote: > BTW, to clarify, does this also turn off ...
6 years, 7 months ago (2014-05-09 22:08:22 UTC) #16
nodir
The CQ bit was checked by nodir@chromium.org
6 years, 7 months ago (2014-05-09 22:10:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nodir@chromium.org/246623009/60001
6 years, 7 months ago (2014-05-09 22:13:39 UTC) #18
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 00:38:28 UTC) #19
Message was sent while issue was closed.
Change committed as 269655

Powered by Google App Engine
This is Rietveld 408576698