third_party/WebKit/public/BUILD.gn - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/BUILD.gn

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: Addressing code review comments from ortuno (still working on test changes) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/BUILD.gn

diff --git a/third_party/WebKit/public/BUILD.gn b/third_party/WebKit/public/BUILD.gn

index baf266ea5aaf494f79a8f10581c951849309bb11..41fd81821a9efd90d9effce005f3643900ce5db4 100644

--- a/third_party/WebKit/public/BUILD.gn

+++ b/third_party/WebKit/public/BUILD.gn

@@ -334,6 +334,8 @@ source_set("blink_headers") {

"platform/modules/bluetooth/WebBluetoothError.h",

"platform/modules/bluetooth/WebBluetoothRemoteGATTCharacteristic.h",

"platform/modules/bluetooth/WebBluetoothRemoteGATTCharacteristicInit.h",

+ "platform/modules/bluetooth/WebBluetoothRemoteGATTDescriptor.h",

+ "platform/modules/bluetooth/WebBluetoothRemoteGATTDescriptorInit.h",

"platform/modules/bluetooth/WebBluetoothRemoteGATTService.h",

"platform/modules/bluetooth/WebRequestDeviceOptions.h",

"platform/modules/device_orientation/WebDeviceMotionData.h",