Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)
Patch Set: Addressing code review comments from ortuno (still working on test changes) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
index 3d704ce4607380636cb327a044f69c3490ac3dd8..f2cc40716e14fcd8bf3266b52f3c454a047eef0a 100644
--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
@@ -31,6 +31,8 @@ DOMException* BluetoothError::take(
"GATT Service no longer exists.");
MAP_ERROR(CHARACTERISTIC_NO_LONGER_EXISTS, InvalidStateError,
"GATT Characteristic no longer exists.");
+ MAP_ERROR(DESCRIPTOR_NO_LONGER_EXISTS, InvalidStateError,
+ "GATT Descriptor no longer exists.");
// NetworkErrors:
MAP_ERROR(CONNECT_ALREADY_IN_PROGRESS, NetworkError,
@@ -95,6 +97,10 @@ DOMException* BluetoothError::take(
"No Characteristics with specified UUID found in Service.");
MAP_ERROR(NO_CHARACTERISTICS_FOUND, NotFoundError,
"No Characteristics found in service.");
+ MAP_ERROR(DESCRIPTOR_NOT_FOUND, NotFoundError,
+ "No Descriptors with specified UUID found in Characteristic.");
+ MAP_ERROR(NO_DESCRIPTORS_FOUND, NotFoundError,
+ "No Descriptors found in Characteristic.");
MAP_ERROR(BLUETOOTH_LOW_ENERGY_NOT_AVAILABLE, NotFoundError,
"Bluetooth Low Energy not available.");
@@ -112,6 +118,9 @@ DOMException* BluetoothError::take(
// SecurityErrors:
MAP_ERROR(GATT_NOT_AUTHORIZED, SecurityError,
"GATT operation not authorized.");
+ MAP_ERROR(BLACKLISTED_DESCRIPTOR_UUID, SecurityError,
+ "getDescriptor(s) called with blacklisted UUID. "
+ "https://goo.gl/4NeimX");
MAP_ERROR(BLACKLISTED_CHARACTERISTIC_UUID, SecurityError,
"getCharacteristic(s) called with blacklisted UUID. "
"https://goo.gl/4NeimX");

Powered by Google App Engine
This is Rietveld 408576698