third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: Addressing code review comments from ortuno (still working on test changes) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/test/mock_bluetooth_gatt_characteristic.h ('K') | « third_party/WebKit/LayoutTests/bluetooth/getDescriptors/invalid-descriptors-name.html ('k') | third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js

diff --git a/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js b/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js

index 993ffbcc3de8ae12dcbb61d4592e8f1d5c04c2e3..c79880c9c04e28aaedeb750aef1efdc34ef1e5ca 100644

--- a/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js

+++ b/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js

@@ -52,6 +52,16 @@ var battery_level = {

name: 'battery_level',

uuid: '00002a19-0000-1000-8000-00805f9b34fb'

};

+var user_description = {

+ alias: 0x2901,

+ name: 'gatt.characteristic_user_description',

+ uuid: '00002901-0000-1000-8000-00805f9b34fb'

+};

+var client_characteristic_configuration = {

+ alias: 0x2902,

+ name: 'gatt.client_characteristic_configuration',

+ uuid: '00002902-0000-1000-8000-00805f9b34fb'

+};

// The following tests make sure the Web Bluetooth implementation

// responds correctly to the different types of errors the