third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html - Issue 2466223002: Implement WebBluetooth getDescriptor[s]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)

Patch Set: Addressing code review comments from ortuno (still working on test changes) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/test/mock_bluetooth_gatt_characteristic.h ('K') | « device/bluetooth/test/mock_bluetooth_gatt_descriptor.h ('k') | third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-not_found.html » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html b/third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html

new file mode 100644

index 0000000000000000000000000000000000000000..de47e185f05b7319c3ad11798b7f40d03e9f0731

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/bluetooth/getDescriptor/descriptor-found.html

@@ -0,0 +1,23 @@

+<!DOCTYPE html>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

+<script>

+'use strict';

+promise_test(() => {

+ return setBluetoothFakeAdapter('HeartRateAdapter')

+ .then(() => requestDeviceWithKeyDown({

+ filters: [{services: ['heart_rate']}],

+ optionalServices: ['generic_access']}))

+ .then(device => device.gatt.connect())

+ .then(gattServer => gattServer.getPrimaryService('heart_rate'))

+ .then(service => service.getCharacteristic('heart_rate_measurement'))

+ .then(characteristic => characteristic.getDescriptor(user_description.alias))

+ .then(descriptor => {

+ assert_equals(

+ descriptor.uuid, user_description.uuid,

+ 'Descriptor UUID should be as requested.');

+ })

+}, 'Request for descriptor. Should return right descriptor');

+</script>