Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: content/browser/bluetooth/bluetooth_metrics.cc

Issue 2466223002: Implement WebBluetooth getDescriptor[s] (Closed)
Patch Set: Addressing code review comments from ortuno (still working on test changes) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/bluetooth/bluetooth_metrics.cc
diff --git a/content/browser/bluetooth/bluetooth_metrics.cc b/content/browser/bluetooth/bluetooth_metrics.cc
index c9e540517d0e3603a7503fb9a15ddd536b554390..f9bbe6b49c3775dcd009dd34320277d9d5ad4d7a 100644
--- a/content/browser/bluetooth/bluetooth_metrics.cc
+++ b/content/browser/bluetooth/bluetooth_metrics.cc
@@ -226,6 +226,7 @@ void RecordGetCharacteristicsOutcome(
UMAGetCharacteristicOutcome::NO_SERVICE);
return;
case CacheQueryOutcome::NO_CHARACTERISTIC:
+ case CacheQueryOutcome::NO_DESCRIPTOR:
NOTREACHED();
return;
}
@@ -262,6 +263,10 @@ void RecordGATTOperationOutcome(UMAGATTOperation operation,
case UMAGATTOperation::START_NOTIFICATIONS:
RecordStartNotificationsOutcome(outcome);
return;
+ case UMAGATTOperation::DESCRIPTOR_READ:
+ case UMAGATTOperation::DESCRIPTOR_WRITE:
+ // TODO(crbug.com/667319): Record descriptor interactions.
+ return;
case UMAGATTOperation::COUNT:
NOTREACHED();
return;
@@ -283,6 +288,8 @@ static UMAGATTOperationOutcome TranslateCacheQueryOutcomeToGATTOperationOutcome(
return UMAGATTOperationOutcome::NO_SERVICE;
case CacheQueryOutcome::NO_CHARACTERISTIC:
return UMAGATTOperationOutcome::NO_CHARACTERISTIC;
+ case CacheQueryOutcome::NO_DESCRIPTOR:
+ return UMAGATTOperationOutcome::NO_DESCRIPTOR;
}
NOTREACHED() << "No need to record success or renderer crash";
return UMAGATTOperationOutcome::NOT_SUPPORTED;

Powered by Google App Engine
This is Rietveld 408576698